Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testnet chainId #2103

Merged
merged 12 commits into from
May 16, 2022
Merged

Add testnet chainId #2103

merged 12 commits into from
May 16, 2022

Conversation

zjb0807
Copy link
Member

@zjb0807 zjb0807 commented May 10, 2022 •
edited
Loading

Closes: #2082

TODO:

@zjb0807 zjb0807 requested a review from xlc May 10, 2022 10:42
@zjb0807 zjb0807 marked this pull request as draft May 10, 2022 10:44
xlc
xlc reviewed May 10, 2022
View reviewed changes
Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs migration for existing networks

modules/support/src/evm.rs Outdated Show resolved Hide resolved
@zjb0807 zjb0807 marked this pull request as ready for review May 12, 2022 00:42
shaunxw
shaunxw previously approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

node/service/src/chain_spec/acala.rs Outdated Show resolved Hide resolved
node/service/src/chain_spec/karura.rs Outdated Show resolved Hide resolved
node/service/src/chain_spec/acala.rs Outdated Show resolved Hide resolved
node/service/src/chain_spec/karura.rs Outdated Show resolved Hide resolved
@zjb0807 zjb0807 enabled auto-merge (squash) May 12, 2022 12:05
@zjb0807 zjb0807 merged commit 99f8e73 into master May 16, 2022
@zjb0807 zjb0807 deleted the add-testnet-chainid branch May 16, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

@shaunxw shaunxw shaunxw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Karura and Acala testnet evm chainId
3 participants
@zjb0807 @xlc @shaunxw