Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert rebase token amount when calculate swap amount for StableAsset #2169

Merged
merged 6 commits into from
Jun 8, 2022

Conversation

wangjj9219
Copy link
Member

No description provided.

@wangjj9219 wangjj9219 changed the title Convert rebased token amount then calculate swap amount for StableAsset Convert rebase token amount when calculate swap amount for StableAsset May 28, 2022
@wangjj9219 wangjj9219 marked this pull request as ready for review May 28, 2022 13:43
@wangjj9219 wangjj9219 requested review from xlc and zqhxuyuan May 29, 2022 11:57
Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to handle the rebase token is to create another implementation of StableAsset that wraps the original one and handle the rebase logic there.

@wangjj9219
Copy link
Member Author

Another way to handle the rebase token is to create another implementation of StableAsset that wraps the original one and handle the rebase logic there.

You are right, it's better to add a wrapper to hide the processing logic, and it will be easier to use for other pallet modules. StableAsset has lots of function definitions, I will do this in the next pr.

@xlc xlc merged commit 92daa48 into master Jun 8, 2022
@xlc xlc deleted the new-call branch June 8, 2022 03:56
syan095 pushed a commit that referenced this pull request Jun 16, 2022
…a into fee_distribution

* 'fee_distribution' of ssh://github.com/AcalaNetwork/Acala: (31 commits)
  update polkadot-v0.9.23 (#2183)
  make sure acala precompiles are called only from other contracts (#2202)
  remove AccountId from XcmFeeToTreasury
  Acala XcmFeeToTreasury
  fix precompile array encode & other improvements (#2196)
  move HomaTreasuryPalletId to common
  update loan proxy type (#2200)
  Add bifrost (#2199)
  fix benchmark
  build_pool_percents helper method
  benchmark
  update to v0.9.22
  refactor weight trader (#2178)
  fix with_fee_currency (#2194)
  Support arm64 (#2107)
  add Homa to ProxyType (#2191)
  disable with_fee_paid_by (#2187)
  Convert rebase token amount when calculate swap amount for StableAsset (#2169)
  2.7.0 (#2186)
  fix origin of erc20 xtokens transfer (#2180)
  ...

# Conflicts:
#	modules/cdp-engine/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants