Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SetEvmOrigin order #2302

Merged
merged 4 commits into from
Aug 2, 2022
Merged

Change SetEvmOrigin order #2302

merged 4 commits into from
Aug 2, 2022

Conversation

zqhxuyuan
Copy link
Contributor

@zqhxuyuan zqhxuyuan commented Jul 31, 2022 •
edited
Loading

Following #2237

the transfer() of Currencies for Erc20 need make sure Origin exists. this PR will set origin before transfer() invoked.

Change SetEvmOrigin in front of ChargeTransactionPayment, and also set origin in validte of SetEvmOrigin, then transfer erc20 happended inside validate of ChargeTransactionPayment can success.

@zqhxuyuan zqhxuyuan requested review from xlc and zjb0807 July 31, 2022 15:29
@zqhxuyuan zqhxuyuan changed the title Payment set evm origin Change SetEvmOrigin order Aug 1, 2022
@zqhxuyuan zqhxuyuan marked this pull request as ready for review August 1, 2022 02:40
xlc
xlc previously approved these changes Aug 1, 2022
View reviewed changes
runtime/acala/src/lib.rs Show resolved Hide resolved
@zqhxuyuan zqhxuyuan merged commit 1d98cdb into master Aug 2, 2022
@zqhxuyuan zqhxuyuan deleted the payment_set_origin branch August 2, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjb0807 zjb0807 zjb0807 approved these changes

@xlc xlc xlc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zqhxuyuan @xlc @zjb0807