Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip checking relay chain block numbers on testnet #2346

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Skip checking relay chain block numbers on testnet #2346

merged 3 commits into from
Sep 20, 2022

Conversation

zjb0807
Copy link
Member

@zjb0807 zjb0807 commented Sep 16, 2022

Closes: #2342

xlc
xlc reviewed Sep 16, 2022
View reviewed changes
Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some test to confirm will be nice

runtime/common/src/lib.rs Outdated Show resolved Hide resolved
xlc
xlc previously approved these changes Sep 19, 2022
View reviewed changes
@zjb0807 zjb0807 merged commit 315da9f into master Sep 20, 2022
@zjb0807 zjb0807 deleted the testnet-relaychain-check branch September 20, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunxw shaunxw shaunxw approved these changes

@xlc xlc xlc left review comments

@ermalkaleci ermalkaleci Awaiting requested review from ermalkaleci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not check relayNumber when the evm.chainId is mandala/karura-testnet/acala-testnet
3 participants
@zjb0807 @xlc @shaunxw