fix eth_getLogs for latest block timing issue
#828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunjizhan
changed the title
eth_getLogs for latest block timing issue
zjb0807
reviewed
Sep 20, 2023
zjb0807
approved these changes
Sep 20, 2023
This was referenced Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
when query logs for a block as soon as it's finalized, it will return empty logs since subql is still indexing this block. This is usually fine but breaks subquery log handlers, which exactly queries logs for a block as soon as it's finalized.
Change
adds a check for get logs to make sure it waits until the indexer finished indexing required range, since now we don't support unfinalized logs, so the upper bound is latest finalized log.
Test
did some manual test locally, and the subql issue seems to be gone