Add e2e tests #62

ThunderDeliverer · 2021-09-28T00:09:40Z

Add end-to-end tests

This branch introduces tests to the predeployed contracts and migrates from Truffle to Waffle.

The changes are separated in branches:

Migrate from Truffle to Waffle
- Includes addition of packages and small configuration changes
Add Token test
- Test suite to test the token contracts
Add DEX test
- Test suite to test the DEX contract
Add Oracle test
- Test suite to test the oracle contract
Add Schedule test
- Test suite to test the schedule contract
Add StateRent test
- Test suite to test the state rent contract

NOTE: I'll keep this in draft until the suite is ready.

Removed Truffle from the project, since it was not being used, and added Waffle testing framework and the required configuration to the project. solc dependency had to be explicitly added in order to support version ^0.8.0, as the highest linked version in Waffle is ^0.6.0.

Added tests to test the operation of Tokens.

zjb0807 · 2021-09-28T02:18:54Z

Maybe it would be better to put all e2e tests here. @xlc
AcalaNetwork/Acala#1437

xlc · 2021-09-28T22:50:45Z

yeah I think it make sense to have this merged with the one in Acala main repo.

Added tests to verify the correct DEX operation.

Added tests to verify the expected operation of Oracle.

ThunderDeliverer · 2021-09-29T00:59:36Z

Sure, I'll merge it (through a new PR) once I'm done with the tests. Should be tomorrow.

Added tests to test the expected operation of Schedule.

ThunderDeliverer · 2021-09-30T17:29:28Z

test/Schedule.test.ts

+  it("emits RescheduledCall event when rescheduling a call and executes it at a new time", async () => {
+    const call = await dex.populateTransaction.swapWithExactSupply([ADDRESS.DOT, ADDRESS.AUSD], 200, 1);
+    const first_target_block_number = Number(await provider.api.query.system.number()) + 5;
+    const second_target_block_number = Number(await provider.api.query.system.number()) + 10;
+    let iface = new ethers.utils.Interface(SCHEDULE_ABI);
+
+    let current_block_number = Number(await provider.api.query.system.number());
+    await schedule.scheduleCall(ADDRESS.DOT, 0, 300000, 10000, 5, ethers.utils.hexlify(call.data as string));
+
+    let block_hash = await provider.api.query.system.blockHash(current_block_number);
+    const data = await provider.api.derive.tx.events(block_hash);
+    let event = data.events.filter(item => item.event.data.some(data => data.address == ADDRESS.Schedule && data.topics[0] == iface.getEventTopic(iface.getEvent("ScheduledCall"))));
+
+    if (event.length > 0) {
+      let log = {
+        topics: [event[0].event.data[0].topics[0].toString(), event[0].event.data[0].topics[1].toString(), event[0].event.data[0].topics[2].toString()], data: event[0].event.data[0].data.toString()
+      };
+      let decode_log = await iface.parseLog(log);
+      await expect(schedule.rescheduleCall(7, ethers.utils.hexlify(decode_log.args.task_id)))
+        .to.emit(schedule, "RescheduledCall")
+        .withArgs(await wallet.getAddress(), ethers.utils.hexlify(decode_log.args.task_id));
+    } else {
+      expect(false).to.be.ok;
+    };


@xlc @zjb0807 I could use another set of eyes on this one. For some reason, the event ScheduledCall is never emitted and without it, I can't test the reschedule call. I went over this setup a couple of times and can't find the issue. This should pass and the setup is done in the same way as in previous examples.

I fixed it, you can refer to it to modify others.

There was one additional one. I updated it in a same manner you fixed this example. Thank you! 🙏

Added tests to validate the expected operation of StateRent.

Cleaned up the tests and modified the remaining Schedule example to the new way of retrieving the events.

ThunderDeliverer · 2021-10-04T00:36:18Z

Maybe it would be better to put all e2e tests here. @xlc AcalaNetwork/Acala#1437

I've been thinking about this. Maybe it would make sense to add these tests to both repositories? We have them and it's good to use them wherever we can. What do you to think @xlc and @zjb0807 ?

Actually the more I think about it, the more sense it makes for the tests to be here. They will be added to AcalaNetwork/Acala repository once the reference to this repository gets updated.

xlc · 2021-10-04T02:16:33Z

We need the tests in Acala repo so it can be ran by CI

ThunderDeliverer · 2021-10-04T19:51:24Z

I could open up a PR to add the tests contained in the predeploy-contracts repository to the CI in Acala:

.PHONY: test-predeployed
test-predeployed:
	cargo build --features with-mandala-runtime
	cd predeploy-contracts && yarn && yarn build && yarn test

xlc · 2021-10-04T22:43:53Z

I am ok to have this merged and then we can see if we want to improve the workflow.

ThunderDeliverer added 2 commits September 28, 2021 00:50

Add Tokens test

7d90f38

Added tests to test the operation of Tokens.

xlc requested a review from zjb0807 September 28, 2021 02:00

ThunderDeliverer added 2 commits September 29, 2021 02:11

Add DEX tests

f64724b

Added tests to verify the correct DEX operation.

Add Oracle tests

02c854d

Added tests to verify the expected operation of Oracle.

Add Schedule tests

7df559a

Added tests to test the expected operation of Schedule.

ThunderDeliverer force-pushed the add-e2e-tests branch from dbfdf85 to 7df559a Compare September 30, 2021 17:25

ThunderDeliverer commented Sep 30, 2021

View reviewed changes

ThunderDeliverer and others added 3 commits October 1, 2021 02:18

Add StateRent tests

3eda830

Added tests to validate the expected operation of StateRent.

fix RescheduledCall

0b59497

Cleanup the e2e tests

a4eba06

Cleaned up the tests and modified the remaining Schedule example to the new way of retrieving the events.

ThunderDeliverer marked this pull request as ready for review October 5, 2021 20:51

zjb0807 mentioned this pull request Apr 28, 2022

Use hardhat instead of truffle #94

Merged

ferrell-code mentioned this pull request Jul 19, 2022

Fix adjust loan bug #115

Merged

ferrell-code added 4 commits July 20, 2022 23:15

conflicts

bae1f96

sync with master branch

1c4d2b6

get DEX and EVM tests updated

ac6c4d8

some more tweeks

9a728bc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add e2e tests #62

Add e2e tests #62

ThunderDeliverer commented Sep 28, 2021 •

edited

Loading

zjb0807 commented Sep 28, 2021

xlc commented Sep 28, 2021

ThunderDeliverer commented Sep 29, 2021

ThunderDeliverer Sep 30, 2021

zjb0807 Oct 1, 2021

zjb0807 Oct 1, 2021

ThunderDeliverer Oct 4, 2021

ThunderDeliverer commented Oct 4, 2021 •

edited

Loading

xlc commented Oct 4, 2021

ThunderDeliverer commented Oct 4, 2021

xlc commented Oct 4, 2021

Add e2e tests #62

Are you sure you want to change the base?

Add e2e tests #62

Conversation

ThunderDeliverer commented Sep 28, 2021 • edited Loading

Add end-to-end tests

zjb0807 commented Sep 28, 2021

xlc commented Sep 28, 2021

ThunderDeliverer commented Sep 29, 2021

ThunderDeliverer Sep 30, 2021

Choose a reason for hiding this comment

zjb0807 Oct 1, 2021

Choose a reason for hiding this comment

zjb0807 Oct 1, 2021

Choose a reason for hiding this comment

ThunderDeliverer Oct 4, 2021

Choose a reason for hiding this comment

ThunderDeliverer commented Oct 4, 2021 • edited Loading

xlc commented Oct 4, 2021

ThunderDeliverer commented Oct 4, 2021

xlc commented Oct 4, 2021

ThunderDeliverer commented Sep 28, 2021 •

edited

Loading

ThunderDeliverer commented Oct 4, 2021 •

edited

Loading