Postpone requiring Int
dimensions in IfThenElse and Stencil
#549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As was done for the
Shape
type class in 9ece31c, this PR modifies theIfThenElse
andStencil
type classes to only require the dimensionality of the array to be known before selecting the instance. The fact that the index types for each of the dimensions is in factInt
is only asserted with a type-equality in the instance context (i.e. only applied after the instance is selected).Motivation and context
Previously, writing code like this:
would generate this error:
which is not very helpful for the user. The updated instances will instead result in this error:
which is somewhat more helpful.
A student ran into this. Similarly, another student ran into the Stencil case, which is also updated in this PR.
How has this been tested?
Tests pass.
Types of changes
Checklist
Go over all the following points, and put an
x
in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!