Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub code analysis #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

skofgar
Copy link
Contributor

@skofgar skofgar commented Apr 2, 2022

It will "Automatically detect common vulnerability and coding errors".
This might be handy feature to have going in CI.

I did run it on my fork and it scanned through 34'225 of Java and about 500 lines of JavaScript. It did not discover any issues, but regardless it might be useful in the future.

The workflow definition is from GitHub's template.

@skofgar skofgar changed the title This adds GitHub's code analysis feature Add GitHub code analysis Apr 2, 2022
@skofgar
Copy link
Contributor Author

skofgar commented Apr 2, 2022

Oh, now it did find something. The extensions/api-playground/src/main/resources/public/swagger-ui-bundle.js could probably be excluded from the security scanning or be updated to a newer version.

@skofgar skofgar mentioned this pull request Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant