#139: improve how LastLogin is shown in users.md

it gets updated on create & on update even without a login
Accenture · Mar 23, 2023 · 225f2a2 · 225f2a2
1 parent af4afd6
commit 225f2a2
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/metadataTypes/User.js b/lib/metadataTypes/User.js
@@ -983,6 +983,7 @@ class User extends MetadataType {
                     .join(',<br> ');
             }
             const defaultBUName = this._getBuName(user.DefaultBusinessUnit);
+            const LastSuccessfulLogin = user.LastSuccessfulLogin.split('.')[0];
             users.push({
                 TYPE: user.c__type,
                 UserID: user.UserID,
@@ -999,7 +1000,11 @@ class User extends MetadataType {
                 AssociatedBus: associatedBus,
                 Roles: roles,
                 LastSuccessfulLogin: user.LastSuccessfulLogin
-                    ? this._timeSinceDate(user.LastSuccessfulLogin)
+                    ? // on create & update, LastSuccessfulLogin often gets overwritten with the current date
+                      LastSuccessfulLogin === user.CreatedDate.split('.')[0] ||
+                      LastSuccessfulLogin === user.ModifiedDate.split('.')[0]
+                        ? 'unknown'
+                        : this._timeSinceDate(user.LastSuccessfulLogin)
                     : 'never',
                 CreatedDate: user.CreatedDate ? user.CreatedDate.split('T').join(' ') : 'n/a',
                 ModifiedDate: user.ModifiedDate ? user.ModifiedDate.split('T').join(' ') : 'n/a',