#0: hotfixes for dataExtension an senderProfile

Accenture · Nov 9, 2024 · 541952b · 541952b
1 parent a8ca3d2
commit 541952b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 17 deletions.
diff --git a/lib/metadataTypes/DataExtension.js b/lib/metadataTypes/DataExtension.js
@@ -55,6 +55,14 @@ class DataExtension extends MetadataType {
             try {
                 await this.validation('deploy', metadataMap[metadataKey], deployDir);
                 metadataMap[metadataKey] = await this.preDeployTasks(metadataMap[metadataKey]);
+
+                await this.createOrUpdate(
+                    metadataMap,
+                    metadataKey,
+                    false,
+                    metadataToUpdate,
+                    metadataToCreate
+                );
             } catch (ex) {
                 // output error & remove from deploy list
                 Util.logger.error(
@@ -67,13 +75,6 @@ class DataExtension extends MetadataType {
                 filteredByPreDeploy++;
                 continue;
             }
-            await this.createOrUpdate(
-                metadataMap,
-                metadataKey,
-                false,
-                metadataToUpdate,
-                metadataToCreate
-            );
         }
         if (metadataToUpdate.length) {
             Util.logger.info(

diff --git a/lib/metadataTypes/SenderProfile.js b/lib/metadataTypes/SenderProfile.js
@@ -143,16 +143,6 @@ class SenderProfile extends MetadataType {
                 }): AutoForwardToEmailAddress and AutoForwardToName will be ignored because UseDefaultRMMRules is set to true; setting UseDefaultRMMRules to false`
             );
             metadata.UseDefaultRMMRules = false;
-        } else if (
-            !metadata.UseDefaultRMMRules &&
-            (metadata.AutoForwardToEmailAddress === '' || metadata.AutoForwardToName === '')
-        ) {
-            Util.logger.warn(
-                ` - ${this.definition.type} ${metadata[this.definition.nameField]} (${
-                    metadata[this.definition.keyField]
-                }): AutoForwardToEmailAddress and AutoForwardToName are required when UseDefaultRMMRules is set to false; setting UseDefaultRMMRules to true`
-            );
-            metadata.UseDefaultRMMRules = true;
         }
         if (!Util.OPTIONS.matchName) {
             // #4 make sure the name is unique