#1646: fix config not getting updated during mcdev upgrade

Accenture · Sep 2, 2024 · a88a935 · a88a935
1 parent 105c5d2
commit a88a935
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/@types/lib/util/init.config.d.ts.map b/@types/lib/util/init.config.d.ts.map
diff --git a/lib/util/init.config.js b/lib/util/init.config.js
@@ -374,7 +374,6 @@ const Init = {
      * @returns {Promise.<boolean>} install successful or error occured
      */
     async _createIdeConfigFile(fileNameArr, relevantForced, boilerplateFileContent) {
-        let update = false;
         const fileName = fileNameArr.join('');
         const boilerplateFileName = path.resolve(
             __dirname,
@@ -409,17 +408,20 @@ const Init = {
                 Util.logger.info(
                     `- ✋  ${fileName} found with differences to the new standard version. We recommend updating it.`
                 );
-                if (!Util.skipInteraction) {
+                if (Util.skipInteraction) {
+                    todo = 'update';
+                } else {
                     const overrideFile = await confirm({
                         message: 'Would you like to update (override) it?',
                         default: true,
                     });
-                    if (!overrideFile) {
+                    if (overrideFile) {
+                        todo = 'update';
+                    } else {
                         // skip override without error
                         return true;
                     }
                 }
-                update = true;
             }
 
             // ensure our update is not leading to data loss in case config files were not versioned correctly by the user
@@ -438,14 +440,16 @@ const Init = {
             if (saveStatus) {
                 Util.logger.info(
                     `- ✔️  ${fileName} ${
-                        update
+                        todo === 'update'
                             ? `updated (we created a backup of the old file under ${fileName + '.BAK'})`
                             : 'created'
                     }`
                 );
                 return true;
             } else {
-                Util.logger.warn(`- ❌  ${fileName} ${update ? 'update' : 'creation'} failed`);
+                Util.logger.warn(
+                    `- ❌  ${fileName} ${todo === 'update' ? 'update' : 'creation'} failed`
+                );
                 return false;
             }
         } else if (todo === 'delete') {