#711: simplify attributeSetIdentifiers

Accenture · Mar 1, 2023 · aa3b710 · aa3b710
1 parent e2e887c
commit aa3b710
Showing 1 changed file with 24 additions and 23 deletions.
diff --git a/lib/metadataTypes/AttributeGroup.js b/lib/metadataTypes/AttributeGroup.js
@@ -44,8 +44,11 @@ class AttributeGroup extends MetadataType {
      * @returns {TYPE.MetadataTypeItem} metadata
      */
     static postRetrieveTasks(metadata) {
+        // Member ID
+        delete metadata.mID;
+
         // attributeSet
-        for (const attributeSet of metadata.attributeSetIdentifiers) {
+        metadata.attributeSetIdentifiers = metadata.attributeSetIdentifiers.map((attributeSet) => {
             try {
                 const key = cache.searchForField(
                     'attributeSet',
@@ -58,19 +61,19 @@ class AttributeGroup extends MetadataType {
                         `AttributeSet key mismatch. Found ${key} instead of ${attributeSet.definitionKey}`
                     );
                 }
-                delete attributeSet.definitionID;
-                delete attributeSet.definitionName;
-                delete attributeSet.connectingID;
+                return key;
             } catch (ex) {
                 Util.logger.warn(
                     ` - ${this.definition.type} ${metadata[this.definition.keyField]} (for ${
                         attributeSet.definitionKey
                     }): ${ex.message}`
                 );
+                return attributeSet;
             }
-        }
-        // Member ID
-        delete metadata.mID;
+        });
+
+        // requiredRelationships
+        // TODO: implement
 
         return metadata;
     }
@@ -81,25 +84,23 @@ class AttributeGroup extends MetadataType {
      * @returns {TYPE.MetadataTypeItem} Promise
      */
     static async preDeployTasks(metadata) {
-        // attributeSet
-        for (const attributeSet of metadata.attributeSetIdentifiers) {
-            try {
-                const as = cache.getByKey('attributeSet', attributeSet.definitionKey);
-                attributeSet.definitionID = as.definitionID;
-                attributeSet.definitionName = as.definitionName?.value;
-                attributeSet.connectingID = as.connectingID;
-            } catch (ex) {
-                Util.logger.warn(
-                    ` - ${this.definition.type} ${metadata[this.definition.keyField]}: ${
-                        ex.message
-                    }`
-                );
-            }
-        }
-
         // Member ID - set to ID of deployment target automatically
         metadata.mID = this.buObject.mid;
 
+        // attributeSet
+        metadata.attributeSetIdentifiers = metadata.attributeSetIdentifiers.map((key) => {
+            const as = cache.getByKey('attributeSet', key);
+            return {
+                definitionKey: key,
+                definitionID: as.definitionID,
+                definitionName: as.definitionName,
+                connectingID: as.connectingID,
+            };
+        });
+
+        // requiredRelationships
+        // TODO: implement
+
         return metadata;
     }
 }