Skip to content

Commit

Permalink
Merge pull request #587 from Accenture/586-task-warning-about-skippin…
Browse files Browse the repository at this point in the history
…g-folder-creation-confusing

#586: enhance folder log message to reduce confusion
  • Loading branch information
DougMidgley authored Dec 7, 2022
2 parents 3ab19ae + 1ff2e6e commit be0d81c
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions lib/Deployer.js
Original file line number Diff line number Diff line change
Expand Up @@ -328,11 +328,11 @@ class Deployer {
const allowedDeFolderContentTypes = ['dataextension', 'shared_dataextension'];
for (const metadataType of metadataTypeArr) {
if (!MetadataTypeInfo[metadataType].definition.dependencies.includes('folder')) {
Util.logger.debug(` ☇ skipping ${metadataType}: folder not a dependency`);
Util.logger.debug(` ☇ skipping ${metadataType} folders: folder not a dependency`);
continue;
}
if (!MetadataTypeInfo[metadataType].definition.folderType) {
Util.logger.debug(` ☇ skipping ${metadataType}: folderType not set`);
Util.logger.debug(` ☇ skipping ${metadataType} folders: folderType not set`);
continue;
}
if (
Expand All @@ -341,11 +341,13 @@ class Deployer {
)
) {
Util.logger.warn(
` ☇ skipping ${metadataType}: folderType ${MetadataTypeInfo[metadataType].definition.folderType} not supported for deployment`
` ☇ skipping ${metadataType} folders: folderType ${MetadataTypeInfo[metadataType].definition.folderType} not supported for deployment. Please consider creating folders for this type manually as a pre-deployment step, if you see errors about missing dependent folders for this type later in this log.`
);
continue;
}
Util.logger.debug(`Creating relevant folders for ${metadataType} in deploy dir`);
Util.logger.debug(
` - create ${metadataType} folders: Creating relevant folders in deploy dir`
);

const allFolders = Object.keys(metadata[metadataType])
.filter(
Expand Down

0 comments on commit be0d81c

Please sign in to comment.