#1270: fox Prototype-polluting assignment warning

Accenture · Jun 6, 2024 · d02f08e · d02f08e
1 parent 40899c7
commit d02f08e
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 2 deletions.
diff --git a/@types/lib/index.d.ts.map b/@types/lib/index.d.ts.map
diff --git a/@types/lib/util/util.d.ts b/@types/lib/util/util.d.ts
@@ -83,6 +83,15 @@ export namespace Util {
      * @returns {boolean} type ok or not
      */
     function _isValidType(selectedType: string, handleOutside?: boolean): boolean;
+    /**
+     * helper for Mcdev.retrieve, Mcdev.retrieveAsTemplate and Mcdev.deploy
+     *
+     * @param {Mcdevrc} properties javascript object in .mcdevrc.json
+     * @param {string} businessUnit name of BU
+     * @param {boolean} [handleOutside] if the API reponse is irregular this allows you to handle it outside of this generic method
+     * @returns {boolean} bu found or not
+     */
+    function _isValidBU(properties: import("../../types/mcdev.d.js").Mcdevrc, businessUnit: string, handleOutside?: boolean): boolean;
     /**
      * helper that deals with extracting type and subtype
      *

diff --git a/@types/lib/util/util.d.ts.map b/@types/lib/util/util.d.ts.map
diff --git a/lib/index.js b/lib/index.js
@@ -1047,6 +1047,9 @@ class Mcdev {
         this.setOptions({ referenceFrom, referenceTo });
 
         const properties = await config.getProperties();
+        if (!Util._isValidBU(properties, businessUnit)) {
+            return;
+        }
         if (selectedTypesArr) {
             // check if types are valid
             for (const selectedType of Object.keys(selectedTypesArr)) {

diff --git a/lib/util/util.js b/lib/util/util.js
@@ -213,6 +213,30 @@ export const Util = {
         return true;
     },
 
+    /**
+     * helper for Mcdev.retrieve, Mcdev.retrieveAsTemplate and Mcdev.deploy
+     *
+     * @param {Mcdevrc} properties javascript object in .mcdevrc.json
+     * @param {string} businessUnit name of BU
+     * @param {boolean} [handleOutside] if the API reponse is irregular this allows you to handle it outside of this generic method
+     * @returns {boolean} bu found or not
+     */
+    _isValidBU(properties, businessUnit, handleOutside) {
+        const [cred, bu] = businessUnit ? businessUnit.split('/') : [null, null];
+        if (!properties.credentials[cred]) {
+            if (!handleOutside) {
+                Util.logger.error(`Credential not found`);
+            }
+            return false;
+        } else if (!properties.credentials[cred].businessUnits[bu]) {
+            if (!handleOutside) {
+                Util.logger.error(`BU not found in credential`);
+            }
+            return false;
+        }
+        return true;
+    },
+
     /**
      * helper that deals with extracting type and subtype
      *