#1403: tslint fixes

Accenture · Jul 5, 2024 · e4fe2a9 · e4fe2a9
1 parent 63d8d44
commit e4fe2a9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -1011,12 +1011,11 @@ class Mcdev {
      *
      * @param {string} businessUnit name of BU
      * @param {TypeKeyCombo | undefined} selectedTypesObj limit retrieval to given metadata type
-     * @param {ContentBlockConversionTypes} to what to replace with
-     * @param {ContentBlockConversionTypes[]} [fromList] what to replace
+     * @param {string} to what to replace with
+     * @param {string[]} [fromList] what to replace
      * @returns {Promise.<Object.<string, object>>} key1: business unit name, key2:type value: list of fixed item keys
      */
     static async replaceCbReference(businessUnit, selectedTypesObj, to, fromList) {
-        /** @type {ContentBlockConversionTypes[]} */
         const allowedFromTo = ['key', 'name', 'id'];
         if (!allowedFromTo.includes(to)) {
             Util.logger.error(

diff --git a/test/type.asset.test.js b/test/type.asset.test.js
@@ -492,7 +492,6 @@ describe('type: asset', () => {
             assert.equal(process.exitCode, 0, 'resolveId should not have thrown an error');
             assert.deepEqual(
                 resolveIdJson,
-                // @ts-expect-error bad typing of assert.deepEqual
                 await testUtils.getExpectedJson('9999999', 'asset', 'resolveId-1295064-noPath'),
                 'returned response was not equal expected'
             );
@@ -521,7 +520,6 @@ describe('type: asset', () => {
             assert.equal(process.exitCode, 0, 'resolveId should not have thrown an error');
             assert.deepEqual(
                 resolveIdJson,
-                // @ts-expect-error bad typing of assert.deepEqual
                 await testUtils.getExpectedJson('9999999', 'asset', 'resolveId-1295064-withPath'),
                 'returned response was not equal expected'
             );
@@ -536,7 +534,6 @@ describe('type: asset', () => {
             // IMPORTANT: this will throw a false "TEST-ERROR" but our testing framework currently needs to not find the file to throw a 404
             assert.deepEqual(
                 resolveIdJson,
-                // @ts-expect-error bad typing of assert.deepEqual
                 await testUtils.getExpectedJson('9999999', 'asset', 'resolveId-1234-notFound'),
                 'returned response was not equal expected'
             );