Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] logger creates -error.log files even if no errors occured #1045

Closed
2 tasks done
JoernBerkefeld opened this issue Jul 24, 2023 · 1 comment · Fixed by #1023 or #1046
Closed
2 tasks done

[BUG] logger creates -error.log files even if no errors occured #1045

JoernBerkefeld opened this issue Jul 24, 2023 · 1 comment · Fixed by #1023 or #1046
Assignees
@JoernBerkefeld
Labels
bug Something isn't working e/IDE EPIC
Milestone
5.2.0

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Jul 24, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

every time the file logger is started, it creates 2 files. one that's only relevant to quickly see errors and one full log

Expected Behavior

the error.log file should only be created if there was an error logged

Version

5.1.0

Participation

  • I am willing to submit a pull request for this issue.
@JoernBerkefeld JoernBerkefeld added bug Something isn't working e/IDE EPIC labels Jul 24, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.2.0 milestone Jul 24, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jul 24, 2023
@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 24, 2023
Merged
JoernBerkefeld added a commit that referenced this issue Jul 24, 2023
@JoernBerkefeld
#1045: remove -error.log file on exit if there was no error
2c40b7b
@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 24, 2023
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Jul 24, 2023 that will close this issue
#1045: remove -error.log file on exit if there was no error #1046
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue Jul 24, 2023
@JoernBerkefeld
Merge pull request #1046 from Accenture/bugfix/1045-logger-creates-er…
1cb3771 
…rorlog-files-even-if-no-errors-occured

#1045: remove -error.log file on exit if there was no error
@github-actions
Copy link

Closed by #1046.

JoernBerkefeld added a commit that referenced this issue Jul 25, 2023
@JoernBerkefeld
#1045: remove empty error log files during log rotation
d705672 
when commands are executed on multiple BUs using the * sign, logs are rotated before switching BUs
JoernBerkefeld added a commit that referenced this issue Jul 25, 2023
@JoernBerkefeld
Revert "#1045: remove empty error log files"
63d6ea9 
This reverts commits d705672 and 2c40b7b
JoernBerkefeld added a commit that referenced this issue Jul 25, 2023
@JoernBerkefeld
#1045: use new lazy flag in winston 3.10.0 to ensure error.log files …
fed0939 
…are only created when needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working e/IDE EPIC
Projects
None yet
Milestone
5.2.0
1 participant
@JoernBerkefeld