Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] rate limit automation retrieval #1048

Closed
2 tasks done
JoernBerkefeld opened this issue Jul 24, 2023 · 2 comments · Fixed by #1054 or #1023
Closed
2 tasks done

[BUG] rate limit automation retrieval #1048

JoernBerkefeld opened this issue Jul 24, 2023 · 2 comments · Fixed by #1054 or #1023
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/automation COMPONENT
Milestone
5.2.0

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

even with few automations found, we are running too many calls in parallel as there is no throttling implemented for this so far:

image

Expected Behavior

we should limit the amount of parallel requests as done for assets and other types

Steps To Reproduce

No response

Version

5.1.0

Environment

No response

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/automation COMPONENT labels Jul 24, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.2.1, 5.2.0 Jul 24, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jul 25, 2023
@JoernBerkefeld
Copy link
Contributor Author

since this can even lead to retrieval failures in edge cases with many automations, prioritizing this for 5.2.0

JoernBerkefeld added a commit that referenced this issue Jul 25, 2023
@JoernBerkefeld
#1048: improve schedule represenation in automation md
eae35f3
JoernBerkefeld added a commit that referenced this issue Jul 25, 2023
@JoernBerkefeld
#1048: add rate limiting to automation retrieve callouts
69704a2
@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 25, 2023
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Jul 25, 2023 that will close this issue
Bugfix/1048 rate limit automation retrieval & improve automation schedule documentation #1054
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue Jul 25, 2023
@JoernBerkefeld
#1048: improve automation md to better signal if an automation was on…
c604906 
…ly scheduled to run once
JoernBerkefeld added a commit that referenced this issue Jul 25, 2023
@JoernBerkefeld
#1048: adjust automation docs to new schedule representation
b0e799d
@github-actions
Copy link

Closed by #1054.

@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/automation COMPONENT
Projects
None yet
Milestone
5.2.0
1 participant
@JoernBerkefeld