Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] test for added/updated fields faulty during update #1177

Closed
2 tasks done
JoernBerkefeld opened this issue Jan 17, 2024 · 2 comments · Fixed by #1694 or #1702
Closed
2 tasks done

[BUG] test for added/updated fields faulty during update #1177

JoernBerkefeld opened this issue Jan 17, 2024 · 2 comments · Fixed by #1694 or #1702
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/dataExtension COMPONENT
Milestone
7.4.1

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Jan 17, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

fields seem to be added twice. they already exist (im assuming based on the deploy-file) and then they are added from cache again by DataExtension.#attachFields(). When DataExtensionField.prepareDeployColumnsOnUpdate() later checks for changes it removes the not-changed fields once but not the second "version" of it.

Expected Behavior

correctly recognized what fields are added or updated and which one are not needed anymore

Version

6.0.1

Participation

  • I am willing to submit a pull request for this issue.
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/dataExtension COMPONENT NEW not yet analyzed new issues get this label labels Jan 17, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 6.0.2, 6.0.3 Jan 17, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.2, 7.0.1 Jun 11, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.0.1, 7.0.2, 7.0.3 Jun 22, 2024
@JoernBerkefeld
Copy link
Contributor Author

potentially related to

@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.1, 7.1.2, 7.1.3 Jul 24, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.6, 7.1.5 Aug 3, 2024
@JoernBerkefeld JoernBerkefeld removed the NEW not yet analyzed new issues get this label label Aug 29, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.5.1, 7.4.1 Sep 11, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 11, 2024
JoernBerkefeld added a commit that referenced this issue Sep 11, 2024
@JoernBerkefeld
#1177: turn field add/update check case insensitive and remove redund…
dffd7d0 
…ant caching

addresses issue for field names that have changes in letter casing
@JoernBerkefeld JoernBerkefeld mentioned this issue Sep 11, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Sep 11, 2024 that will close this issue
bug/1177 make field add/update check case insensitive and remove redundant caching #1694
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue Sep 11, 2024
@JoernBerkefeld
#1177: cleanup & code comments
122c70c
@github-actions GitHub Actions
Copy link

Closed by #1694.

@JoernBerkefeld JoernBerkefeld mentioned this issue Sep 12, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/dataExtension COMPONENT
Projects
None yet
Milestone
7.4.1
1 participant
@JoernBerkefeld