Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] contributor: only run jsdoc2md if js files were committed #1217

Closed
JoernBerkefeld opened this issue Feb 13, 2024 · 1 comment · Fixed by #1193 or #1218
Closed

[TASK] contributor: only run jsdoc2md if js files were committed #1217

JoernBerkefeld opened this issue Feb 13, 2024 · 1 comment · Fixed by #1193 or #1218
Assignees
@JoernBerkefeld
Labels
chore Jira issue-type "Task" contributor improvements for contributing to mcdev
Milestone
7.0.0

Comments

@JoernBerkefeld
Copy link
Contributor

right now we run this on every commit, even if no js files were changed. that slows down the commit for now reason and should be handled via lint-staged instead
@JoernBerkefeld JoernBerkefeld added chore Jira issue-type "Task" contributor improvements for contributing to mcdev labels Feb 13, 2024
@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone Feb 13, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Feb 13, 2024
JoernBerkefeld added a commit that referenced this issue Feb 13, 2024
@JoernBerkefeld
#1217: moving jsdoc2md into lint-staged to speed up commits
0834a8a
@JoernBerkefeld JoernBerkefeld mentioned this issue Feb 13, 2024
Merged
1 task
JoernBerkefeld added a commit that referenced this issue Feb 13, 2024
@JoernBerkefeld
Merge pull request #1218 from Accenture/task/1217-contributor-only-ru…
da8117f 
…n-jsdoc2md-if-js-files-were-committed

#1217: moving jsdoc2md into lint-staged to speed up commits
@github-actions GitHub Actions
Copy link

Closed by #1218.

@JoernBerkefeld JoernBerkefeld mentioned this issue Feb 13, 2024
Merged
10 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Feb 13, 2024 that will close this issue
#1217: moving jsdoc2md into lint-staged to speed up commits #1218
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
chore Jira issue-type "Task" contributor improvements for contributing to mcdev
Projects
None yet
Milestone
7.0.0
1 participant
@JoernBerkefeld