Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] max line width breaks ampscript code in assets #1248

Closed
2 tasks done
JoernBerkefeld opened this issue Apr 8, 2024 · 3 comments · Fixed by #1341 or #1193
Closed
2 tasks done

[BUG] max line width breaks ampscript code in assets #1248

JoernBerkefeld opened this issue Apr 8, 2024 · 3 comments · Fixed by #1341 or #1193
Assignees
Labels
bug Something isn't working c/asset COMPONENT NEW not yet analyzed new issues get this label
Milestone

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

saw it happening with contentblockbyname which tends to have a very longer argument.

Expected Behavior

ampscript code does not get auto-line breaks applied

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

6.0.2

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response

@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/asset COMPONENT NEW not yet analyzed new issues get this label labels Apr 8, 2024
@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone Apr 8, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Apr 8, 2024
@JoernBerkefeld
Copy link
Contributor Author

could be fixed by changing .vscode/settings.json:

    "files.associations": {
        "*.html": "AMPscript"
    },
    "[html]": {
        "editor.defaultFormatter": "FiB.beautyAmp"
    },

that way, we no longer apply prettier settings but instead run beautyAmp on the code. tested this myself already and it seems to work

@JoernBerkefeld
Copy link
Contributor Author

JoernBerkefeld commented Apr 10, 2024

@JoernBerkefeld JoernBerkefeld modified the milestones: 6.1.0, 6.1.1 May 14, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.1, 7.0.0 May 21, 2024
JoernBerkefeld added a commit that referenced this issue May 22, 2024
it runs prettier on html but also formats ampscript
JoernBerkefeld added a commit that referenced this issue May 22, 2024
JoernBerkefeld added a commit that referenced this issue May 22, 2024
…es easier; add amscript-language to recommended extensions for contributors
Copy link

Closed by #1341.

@JoernBerkefeld JoernBerkefeld mentioned this issue May 22, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/asset COMPONENT NEW not yet analyzed new issues get this label
Projects
None yet
1 participant