Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] explainTypes --json returns incorrect value for script.supports.changeKey #1284

Closed
2 tasks done
JoernBerkefeld opened this issue Apr 24, 2024 · 2 comments · Fixed by #1285 or #1193
Closed
2 tasks done

[BUG] explainTypes --json returns incorrect value for script.supports.changeKey #1284

JoernBerkefeld opened this issue Apr 24, 2024 · 2 comments · Fixed by #1285 or #1193
Assignees
@JoernBerkefeld
Labels
bug Something isn't working
Milestone
7.0.0

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

image

Expected Behavior

should return true/false for changeKey

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

6.0.2

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added the bug Something isn't working label Apr 24, 2024
@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone Apr 24, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Apr 24, 2024
@JoernBerkefeld
Copy link
Contributor Author

fyi @anasilva105

JoernBerkefeld added a commit that referenced this issue Apr 24, 2024
@JoernBerkefeld
#1284: fix script.definition file
5384295
JoernBerkefeld added a commit that referenced this issue Apr 24, 2024
@JoernBerkefeld
#1284: add proper typing for explainTypes
cca38a1
@JoernBerkefeld JoernBerkefeld mentioned this issue Apr 24, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link

Closed by #1285.

@JoernBerkefeld JoernBerkefeld linked a pull request Apr 24, 2024 that will close this issue
Bug/1284 explainTypes --json returns incorrect value for script.supports.changekey #1285
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld mentioned this issue Apr 24, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working
Projects
None yet
Milestone
7.0.0
1 participant
@JoernBerkefeld