Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] no owner check for assets #1301

Closed
JoernBerkefeld opened this issue May 6, 2024 · 3 comments · Fixed by #1308 or #1193
Closed

[FEATURE] no owner check for assets #1301

JoernBerkefeld opened this issue May 6, 2024 · 3 comments · Fixed by #1308 or #1193
Assignees
@JoernBerkefeld
Labels
c/asset COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" PRIORITY used for professional service clients
Milestone
7.0.0

Comments

@JoernBerkefeld
Copy link
Contributor

Basically, I want to auto-replace the memberId field on deploy without having to do it via templating.

That way, it is not a breaking change but enables anyone who wants their own suffixes applied via templating to run deploy with the new flag, while everyone else can stay on auto mode

Have to come up with a good name for the flag 🤔
@JoernBerkefeld JoernBerkefeld added c/asset COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" PRIORITY used for professional service clients labels May 6, 2024
@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone May 6, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this May 6, 2024
@JoernBerkefeld
Copy link
Contributor Author

ideas for flags:
--noOwnerCheck
--noMidSuffix
--noAutoSuffix
--force -f

@JoernBerkefeld
Copy link
Contributor Author

settled on --noMidSuffix

JoernBerkefeld added a commit that referenced this issue May 7, 2024
@JoernBerkefeld
#1301: add deploy option --noMidSuffix
47f09eb
JoernBerkefeld added a commit that referenced this issue May 7, 2024
@JoernBerkefeld
#1301: add tests for --noMidSuffix
6027f17
@JoernBerkefeld JoernBerkefeld mentioned this issue May 7, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request May 7, 2024 that will close this issue
Feature/1301 no owner check for assets + Task/905 test callout payloads #1308
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue May 7, 2024
@JoernBerkefeld
#1301: improve test reset logic
4845319
@JoernBerkefeld JoernBerkefeld mentioned this issue May 8, 2024
Merged
10 tasks
@github-actions github-actions bot closed this as completed May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Closed by #1308.

@JoernBerkefeld JoernBerkefeld mentioned this issue May 14, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/asset COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" PRIORITY used for professional service clients
Projects
None yet
Milestone
7.0.0
1 participant
@JoernBerkefeld