Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] automatically add suffix to key #1302

Closed
JoernBerkefeld opened this issue May 6, 2024 · 2 comments · Fixed by #1303, #1193 or #1308
Closed

[FEATURE] automatically add suffix to key #1302

JoernBerkefeld opened this issue May 6, 2024 · 2 comments · Fixed by #1303, #1193 or #1308
Assignees
@JoernBerkefeld
Labels
e/DevOps EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Milestone
7.0.0

Comments

@JoernBerkefeld
Copy link
Contributor

the idea is that if we use deploy --changeKeyField or fixKeys (which is just syntactic sugar on top of the former), we might want to set a suffix identifying our current environment. Thats particularly interesting for shared dataExtensions and for assets. Both have keys that have to be unique across business units.
@JoernBerkefeld JoernBerkefeld added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label May 6, 2024
@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone May 6, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this May 6, 2024
JoernBerkefeld added a commit that referenced this issue May 6, 2024
@JoernBerkefeld
#1302: define max key length for deliveryProfile, SendClassification …
f701d5d 
…and SenderProfile
JoernBerkefeld added a commit that referenced this issue May 6, 2024
@JoernBerkefeld
#1302: --addKeySuffix logic for fixKeys and deploy
966620e
JoernBerkefeld added a commit that referenced this issue May 6, 2024
@JoernBerkefeld
#1302: rename new option to --keySuffix
afe43d4
JoernBerkefeld added a commit that referenced this issue May 6, 2024
@JoernBerkefeld
#1302: add aliases to deploy+fixKeys options
615e6ca
JoernBerkefeld added a commit that referenced this issue May 6, 2024
@JoernBerkefeld
#1302, #1298: --addKeySuffix logic for fixKeys and deploy
1673197
JoernBerkefeld added a commit that referenced this issue May 6, 2024
@JoernBerkefeld
#1302: rename new option to --keySuffix
69b6734
JoernBerkefeld added a commit that referenced this issue May 6, 2024
@JoernBerkefeld
#1302: add aliases to deploy+fixKeys options
84dabf9
@JoernBerkefeld JoernBerkefeld mentioned this issue May 6, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request May 6, 2024 that will close this issue
Feature/1302 + Bugfix/1298 automatically add suffix to key #1303
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue May 6, 2024
@JoernBerkefeld
#1302: add missing reset
1223306
JoernBerkefeld added a commit that referenced this issue May 6, 2024
@JoernBerkefeld
#1302: add tests for deploy --keySuffix and fixKeys --keySuffix
5cd6396
JoernBerkefeld added a commit that referenced this issue May 6, 2024
@JoernBerkefeld
#1302: fix dependent tests
a283839
@github-actions github-actions bot closed this as completed May 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Closed by #1303.

@JoernBerkefeld JoernBerkefeld mentioned this issue May 6, 2024
Merged
10 tasks
JoernBerkefeld added a commit that referenced this issue May 7, 2024
@JoernBerkefeld
#1302: allow --keySuffix to be used for CREATE and without --changeKe…
4069ded 
…yField
JoernBerkefeld added a commit that referenced this issue May 7, 2024
@JoernBerkefeld
#1302: test for --keySuffix on CREATE
9a77946
@JoernBerkefeld JoernBerkefeld mentioned this issue May 7, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request May 7, 2024 that will close this issue
Feature/1301 no owner check for assets + Task/905 test callout payloads #1308
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue May 7, 2024
@JoernBerkefeld
#1302: enhance fixKeys test cases with checks on callout payload
1b54ebf
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Closed by #1308.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
e/DevOps EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
7.0.0
1 participant
@JoernBerkefeld