Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] auto-enable AllowChildren on folders during deployment of subfolders #1318

Closed
2 tasks done
JoernBerkefeld opened this issue May 14, 2024 · 1 comment · Fixed by #1319 or #1193
Closed
2 tasks done

[FEATURE] auto-enable AllowChildren on folders during deployment of subfolders #1318

JoernBerkefeld opened this issue May 14, 2024 · 1 comment · Fixed by #1319 or #1193
Assignees
@JoernBerkefeld
Labels
c/folder COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Milestone
7.0.0

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented May 14, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

<CreateResponse xmlns="http://exacttarget.com/wsdl/partnerAPI">
    <Results>
        <StatusCode>Error</StatusCode>
        <StatusMessage>ParentFolder "Content Blocks Library" cannot contain child folders.</StatusMessage>
        <OrdinalID>0</OrdinalID>
        <ErrorCode>396007</ErrorCode>
        <NewID>0</NewID>
    </Results>
    <RequestID>0c018687-e4dd-451b-962a-489d67b9928f</RequestID>
    <OverallStatus>Error</OverallStatus>
</CreateResponse>

ErrorCode: 396007
StatusMessage: ParentFolder "Content Blocks Library" cannot contain child folders.

Expected Behavior

options:

  • show a readable error message and the option to enable having children on that folder with just a Y/n question
  • auto-fix it silently

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

6.0.2

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" c/folder COMPONENT labels May 14, 2024
@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone May 14, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this May 14, 2024
JoernBerkefeld added a commit that referenced this issue May 14, 2024
@JoernBerkefeld
#1318: ensure we update existing folders if IsActive, IsEditable or A…
e4c73ae 
…llowChildren is set to false
JoernBerkefeld added a commit that referenced this issue May 14, 2024
@JoernBerkefeld
#1318: removed "Description" from auto-generated folders to avoid acc…
edcdffe 
…idental overrides during update
@JoernBerkefeld JoernBerkefeld mentioned this issue May 14, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request May 14, 2024 that will close this issue
BREAKING Feature/1318 auto enable allowchildren on folders during deployment of subfolders #1319
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld mentioned this issue May 14, 2024
Merged
10 tasks
@github-actions GitHub Actions
Copy link

Closed by #1319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/folder COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
7.0.0
1 participant
@JoernBerkefeld