Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] buildTemplate and buildDefinition for assets copies non-json files into subfolders that have template-variable in them #1324

Closed
2 tasks done
JoernBerkefeld opened this issue May 15, 2024 · 1 comment · Fixed by #1328
Closed
2 tasks done

[BUG] buildTemplate and buildDefinition for assets copies non-json files into subfolders that have template-variable in them #1324

JoernBerkefeld opened this issue May 15, 2024 · 1 comment · Fixed by #1328
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/asset COMPONENT e/DevOps EPIC
Milestone
7.0.0

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

image

Expected Behavior

both files should have been in the _DEV folder

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

6.0.2

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working e/DevOps EPIC c/asset COMPONENT labels May 15, 2024
@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone May 15, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this May 15, 2024
JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#1324: fix buildTemplate for asset-message and asset-template, webpage
1a149f3
JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#1324: ensure MID can be templated in memberId field of assets withou…
fc885ad 
…t breaking json
JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#1324: handle template-source-not-found more gracefully for asset
0b305ee
JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#1324: handle template more gracefully for asset
0ee670a
JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#1324: fix buildDefinition for types with their own subfolder per item
61eb852
JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#1324: add templating test for assets: templatebased-emails
9796b82
@JoernBerkefeld JoernBerkefeld mentioned this issue May 16, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request May 16, 2024 that will close this issue
Bug/1324 buildTemplate/buildDefinition for assets copies non json files into subfolders that have template variable in them + Bug/798 replacing MIDs in JSONs break buildTemplate #1328
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld changed the title [BUG] buildTemplate for assets copies non-json files into subfolders that have template-variable in them [BUG] buildTemplate and buildDefinition for assets copies non-json files into subfolders that have template-variable in them May 16, 2024
JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#1324: handle template-source-not-found more gracefully for asset
22f06c8
JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#1324: handle template more gracefully for asset
ee20625
JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#1324: fix buildDefinition for types with their own subfolder per item
40a77a4
JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#1324: add templating test for assets: templatebased-emails
976758a
JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#1324: fix returned path for asset getFilesToCommit
94317a3
@github-actions GitHub Actions
Copy link

Closed by #1328.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/asset COMPONENT e/DevOps EPIC
Projects
None yet
Milestone
7.0.0
1 participant
@JoernBerkefeld