Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] exclude event from fixKeys* #1334

Closed
JoernBerkefeld opened this issue May 17, 2024 · 1 comment · Fixed by #1345 or #1193
Closed

[TASK] exclude event from fixKeys* #1334

JoernBerkefeld opened this issue May 17, 2024 · 1 comment · Fixed by #1345 or #1193
Labels
c/event COMPONENT chore Jira issue-type "Task" NEW not yet analyzed new issues get this label
Milestone
7.0.0

Comments

@JoernBerkefeld
Copy link
Contributor

It breaks journeys because the key is used in decisionsplits and many other places.
Show warning and require confirmation of somebody tries this with type event specified
@JoernBerkefeld JoernBerkefeld added chore Jira issue-type "Task" NEW not yet analyzed new issues get this label labels May 17, 2024
@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone May 17, 2024
@JoernBerkefeld JoernBerkefeld added the c/event COMPONENT label May 23, 2024
JoernBerkefeld added a commit that referenced this issue May 23, 2024
@JoernBerkefeld
#1334: ensure that event is not a permitted type in fixKeys
f09203c
JoernBerkefeld added a commit that referenced this issue May 23, 2024
@JoernBerkefeld
#1334: add test for event and fixKeys
6c7dce2
@JoernBerkefeld JoernBerkefeld mentioned this issue May 23, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request May 23, 2024 that will close this issue
Task/1334 exclude event from fixKeys #1345
Merged
4 tasks
@github-actions GitHub Actions
Copy link

Closed by #1345.

@JoernBerkefeld JoernBerkefeld mentioned this issue May 23, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/event COMPONENT chore Jira issue-type "Task" NEW not yet analyzed new issues get this label
Projects
None yet
Milestone
7.0.0
1 participant
@JoernBerkefeld