Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] replaceContentBlock and --dependencies do not recognize keys with spaces #1539

Closed
2 tasks done
JoernBerkefeld opened this issue Aug 2, 2024 · 1 comment · Fixed by #1540 or #1544
Closed
2 tasks done

[BUG] replaceContentBlock and --dependencies do not recognize keys with spaces #1539

JoernBerkefeld opened this issue Aug 2, 2024 · 1 comment · Fixed by #1540 or #1544
Assignees
@JoernBerkefeld
Labels
bug Something isn't working e/DevOps EPIC PRIORITY used for professional service clients
Milestone
7.1.3

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

works:

%%= ContentBlockByKey(  "0b76dccf-594c-b6dc-1acf-10c4493dcb84"  ) =%%

does not work:

%%= ContentBlockByKey(  " 0b76dccf-594c-b6dc-1acf-10c4493dcb84"  ) =%%
%%= ContentBlockByKey(  "0b76dccf-594c-b6dc-1acf-10c4493dcb84 "  ) =%%
%%= ContentBlockByKey(  "0b76dccf 594c b6dc 1acf 10c4493dcb84"  ) =%%

Expected Behavior

should work:
works:

%%= ContentBlockByKey(  "0b76dccf-594c-b6dc-1acf-10c4493dcb84"  ) =%%
%%= ContentBlockByKey(  "0b76dccf 594c b6dc 1acf 10c4493dcb84"  ) =%%

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

7.1.2

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working e/DevOps EPIC PRIORITY used for professional service clients labels Aug 2, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.1.3 milestone Aug 2, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Aug 2, 2024
JoernBerkefeld added a commit that referenced this issue Aug 2, 2024
@JoernBerkefeld
#1539: accept spaces in keys when finding dependencies / replacing Co…
935f9a0 
…ntentBlockByKey
JoernBerkefeld added a commit that referenced this issue Aug 2, 2024
@JoernBerkefeld
#1539: enhance tests to cover keys with spaces
9d3fccd
@JoernBerkefeld JoernBerkefeld mentioned this issue Aug 2, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Aug 2, 2024 that will close this issue
bug/1539 accept spaces in keys when finding dependencies / replacing ContentBlockByKey #1540
Merged
4 tasks
@github-actions github-actions bot closed this as completed Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Closed by #1540.

@JoernBerkefeld JoernBerkefeld mentioned this issue Aug 2, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working e/DevOps EPIC PRIORITY used for professional service clients
Projects
None yet
Milestone
7.1.3
1 participant
@JoernBerkefeld