Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] ensure CreatedDate and ModifiedDate are saved after updates #1616

Closed
JoernBerkefeld opened this issue Aug 28, 2024 · 1 comment · Fixed by #1617 or #1613
Closed

[TASK] ensure CreatedDate and ModifiedDate are saved after updates #1616

JoernBerkefeld opened this issue Aug 28, 2024 · 1 comment · Fixed by #1617 or #1613
Assignees
@JoernBerkefeld
Labels
c/dataExtension COMPONENT c/emailSend COMPONENT c/role COMPONENT c/sendClassification COMPONENT c/senderProfile COMPONENT c/triggeredSend COMPONENT chore Jira issue-type "Task"
Milestone
7.3.0

Comments

@JoernBerkefeld
Copy link
Contributor

due to the way SFMC's SOAP apis work, if you don't "update"/"create" a field, it also won't be returned. due to that, we currently exclude those fields in updates. due to that, one basically has to re-retrieve certain types manually after updates which is unnecessary as the SOAP API simply ignores the values in those 2 fields if send for create/update requests.
@JoernBerkefeld JoernBerkefeld added c/dataExtension COMPONENT c/emailSend COMPONENT c/role COMPONENT c/sendClassification COMPONENT c/senderProfile COMPONENT c/triggeredSend COMPONENT chore Jira issue-type "Task" labels Aug 28, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.2.1 milestone Aug 28, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Aug 28, 2024
JoernBerkefeld added a commit that referenced this issue Aug 28, 2024
@JoernBerkefeld
#1616: have CreatedDate and ModifiedDate in deploy response
9d895c4 
despite those fields not being updatable
@JoernBerkefeld JoernBerkefeld mentioned this issue Aug 28, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Aug 28, 2024 that will close this issue
task/1616 have CreatedDate and ModifiedDate in deploy response #1617
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue Aug 28, 2024
@JoernBerkefeld
#1616: fix event test
ff53b0f
@github-actions GitHub Actions
Copy link

Closed by #1617.

@JoernBerkefeld JoernBerkefeld mentioned this issue Aug 28, 2024
Merged
11 tasks
JoernBerkefeld added a commit that referenced this issue Sep 4, 2024
@JoernBerkefeld
#1616: ensure CreatedDate and ModifiedDate are always send, even if t…
a6cb91f 
…he were omitted due to templating
JoernBerkefeld added a commit that referenced this issue Sep 4, 2024
@JoernBerkefeld
Revert "#1616: ensure CreatedDate and ModifiedDate are always send, e…
1094a21 
…ven if the were omitted due to templating"

This reverts commit a6cb91f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/dataExtension COMPONENT c/emailSend COMPONENT c/role COMPONENT c/sendClassification COMPONENT c/senderProfile COMPONENT c/triggeredSend COMPONENT chore Jira issue-type "Task"
Projects
None yet
Milestone
7.3.0
1 participant
@JoernBerkefeld