Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] improve common-vs-contact checks for Salesforce data entry events #1631

Closed
JoernBerkefeld opened this issue Aug 29, 2024 · 1 comment · Fixed by #1632 or #1635
Closed

[TASK] improve common-vs-contact checks for Salesforce data entry events #1631

JoernBerkefeld opened this issue Aug 29, 2024 · 1 comment · Fixed by #1632 or #1635
Assignees
@JoernBerkefeld
Labels
c/event COMPONENT c/journey COMPONENT chore Jira issue-type "Task"
Milestone
7.3.1

Comments

@JoernBerkefeld
Copy link
Contributor

based one:

essentially, we need to be mindful where we apply the "common object" and where not or we will get incorrect errors
@JoernBerkefeld JoernBerkefeld added c/event COMPONENT c/journey COMPONENT chore Jira issue-type "Task" labels Aug 29, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.3.1 milestone Aug 29, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Aug 29, 2024
JoernBerkefeld added a commit that referenced this issue Aug 29, 2024
@JoernBerkefeld
#1631: ensure Common fields are tracked but originals are kept on Con…
ed13296 
…tact/Lead
JoernBerkefeld added a commit that referenced this issue Aug 29, 2024
@JoernBerkefeld
#1631: correct common-vs-contact logic and fix check of ca.contactKey…
94f62a6 
… logic
JoernBerkefeld added a commit that referenced this issue Aug 29, 2024
@JoernBerkefeld
#1631: checks on passThroughArgument, primaryObjectFilterCriteria, re…
7c63142 
…latedObjectFilterCriteria
@JoernBerkefeld JoernBerkefeld mentioned this issue Aug 29, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Aug 29, 2024 that will close this issue
Task/1631 improve configurationArgument checks incl common vs contact logic for salesforce data entry events #1632
Merged
4 tasks
@github-actions GitHub Actions
Copy link

Closed by #1632.

@JoernBerkefeld JoernBerkefeld mentioned this issue Aug 30, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/event COMPONENT c/journey COMPONENT chore Jira issue-type "Task"
Projects
None yet
Milestone
7.3.1
1 participant
@JoernBerkefeld