Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] optional validation rule overrides for selected types #1666

Closed
JoernBerkefeld opened this issue Sep 3, 2024 · 1 comment · Fixed by #1667 or #1642
Closed

[FEATURE] optional validation rule overrides for selected types #1666

JoernBerkefeld opened this issue Sep 3, 2024 · 1 comment · Fixed by #1667 or #1642
Assignees
@JoernBerkefeld
Labels
e/IDE EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" validationRule
Milestone
7.4.0

Comments

@JoernBerkefeld
Copy link
Contributor

idea is to re-use the format that prettier configs use to allow setting a generic rule plus specific ones for selected types:
image

            "deploy": {
                "keySuffix": "error",
                "noGuidKeys": "error",
                "noRootFolder": "error",
                "overrides": [
                    {
                        "type": ["journey"],
                        "options": {
                            "noGuidKeys": "warn"
                        }
                    }
                ]
            }
@JoernBerkefeld JoernBerkefeld added enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" e/IDE EPIC labels Sep 3, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.4.0 milestone Sep 3, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 3, 2024
JoernBerkefeld added a commit that referenced this issue Sep 3, 2024
@JoernBerkefeld
#1666: refactoring
73f305d
JoernBerkefeld added a commit that referenced this issue Sep 3, 2024
@JoernBerkefeld
#1666: add sample override validation rule to boilerplate config
da0b490
JoernBerkefeld added a commit that referenced this issue Sep 3, 2024
@JoernBerkefeld
#1666: add validation rule overrides by method & type
da09ce5
JoernBerkefeld added a commit that referenced this issue Sep 3, 2024
@JoernBerkefeld
#1666: refactoring & code comments
f37a9b9
@JoernBerkefeld JoernBerkefeld mentioned this issue Sep 3, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Sep 3, 2024 that will close this issue
Feature/1666 optional validation rule overrides for selected types #1667
Merged
4 tasks
@github-actions github-actions bot closed this as completed Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Closed by #1667.

@JoernBerkefeld JoernBerkefeld mentioned this issue Sep 3, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
e/IDE EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" validationRule
Projects
None yet
Milestone
7.4.0
1 participant
@JoernBerkefeld