Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] sf object checks for events and journeys fail if multiple entries are retrieved by key #1668

Closed
1 of 2 tasks
JoernBerkefeld opened this issue Sep 3, 2024 · 1 comment · Fixed by #1669 or #1642
Closed
1 of 2 tasks

[BUG] sf object checks for events and journeys fail if multiple entries are retrieved by key #1668

JoernBerkefeld opened this issue Sep 3, 2024 · 1 comment · Fixed by #1669 or #1642
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/event COMPONENT c/journey COMPONENT
Milestone
7.4.0

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

weird async-await issues. basically the checks run before the data is in.
also, all object/field apis are pinged once per key, making this really inefficient

Expected Behavior

No response

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

7.3.1

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/event COMPONENT c/journey COMPONENT labels Sep 3, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.4.0 milestone Sep 3, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 3, 2024
JoernBerkefeld added a commit that referenced this issue Sep 3, 2024
@JoernBerkefeld
#1668: fix async await issue for sf journeys and sf events when multi…
83b2f57 
…ple keys are retrieved at once
@JoernBerkefeld JoernBerkefeld mentioned this issue Sep 3, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Sep 3, 2024 that will close this issue
Bug/1668 sf object checks for events and journeys fail if multiple entries are retrieved by key #1669
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld mentioned this issue Sep 3, 2024
Merged
11 tasks
@github-actions github-actions bot closed this as completed Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Closed by #1669.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/event COMPONENT c/journey COMPONENT
Projects
None yet
Milestone
7.4.0
1 participant
@JoernBerkefeld