Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] add new validation rule to warn about ampscript getting wrapped in <script> tags #1754

Closed
JoernBerkefeld opened this issue Sep 30, 2024 · 1 comment · Fixed by #1766 or #1767
Closed

[TASK] add new validation rule to warn about ampscript getting wrapped in <script> tags #1754

JoernBerkefeld opened this issue Sep 30, 2024 · 1 comment · Fixed by #1766 or #1767
Assignees
@JoernBerkefeld
Labels
c/asset COMPONENT chore Jira issue-type "Task" validationRule
Milestone
7.4.4

Comments

@JoernBerkefeld
Copy link
Contributor

instead of %%[ ... ]%% one can technically also use <script runat="server" language="ampscript"> ... </script>
however, that will break linting and hence should be discouraged
@JoernBerkefeld JoernBerkefeld added NEW not yet analyzed new issues get this label chore Jira issue-type "Task" labels Sep 30, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.4.4 milestone Sep 30, 2024
@JoernBerkefeld JoernBerkefeld removed the NEW not yet analyzed new issues get this label label Sep 30, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Oct 2, 2024
JoernBerkefeld added a commit that referenced this issue Oct 2, 2024
@JoernBerkefeld
#1754: add new validation rule noAmpscriptHtmlTag
a650b51
JoernBerkefeld added a commit that referenced this issue Oct 2, 2024
@JoernBerkefeld
#1754: improve look and feel of validation rule warnings (if there is…
519e42f 
… more than one per item)
JoernBerkefeld added a commit that referenced this issue Oct 2, 2024
@JoernBerkefeld
#1754: hide "constructing common object" message from CLI
afeef32
@JoernBerkefeld JoernBerkefeld mentioned this issue Oct 2, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Oct 2, 2024 that will close this issue
Task/1754 add new validation rule to warn about ampscript getting wrapped in script tags #1766
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld added the c/asset COMPONENT label Oct 2, 2024
JoernBerkefeld added a commit that referenced this issue Oct 2, 2024
@JoernBerkefeld
#1754: add missing "> to amscript-html check
3f15549
@github-actions github-actions bot closed this as completed Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Closed by #1766.

@JoernBerkefeld JoernBerkefeld mentioned this issue Oct 2, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/asset COMPONENT chore Jira issue-type "Task" validationRule
Projects
None yet
Milestone
7.4.4
1 participant
@JoernBerkefeld