Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] no longer save journey-triggeredSends to disk #1814

Closed
JoernBerkefeld opened this issue Oct 30, 2024 · 2 comments · Fixed by #1816 or #1847
Closed

[TASK] no longer save journey-triggeredSends to disk #1814

JoernBerkefeld opened this issue Oct 30, 2024 · 2 comments · Fixed by #1816 or #1847
Assignees
@JoernBerkefeld
Labels
c/triggeredSend COMPONENT chore Jira issue-type "Task"
Milestone
7.5.0

Comments

@JoernBerkefeld
Copy link
Contributor

reasons:

  1. all relevant data is also stored on the journey itself
  2. every time we re-publish the journey, new triggeredSends get created, leaving us with hundreds of files
  3. the SOAP API used to retrieve them doesn't even return all relevant fields (e.g. CC & BCC)
@JoernBerkefeld JoernBerkefeld added c/triggeredSend COMPONENT chore Jira issue-type "Task" labels Oct 30, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.4.6, 7.4.5 Oct 30, 2024
@JoernBerkefeld
Copy link
Contributor Author

can be done by adding this to triggeredSend.definition.js:

    filter: {
        r__folder_Path: 'Journey Builder Sends/',
    },

@JoernBerkefeld JoernBerkefeld self-assigned this Oct 30, 2024
JoernBerkefeld added a commit that referenced this issue Oct 30, 2024
@JoernBerkefeld
#1814: filter journey builder triggeredSends from being saved to disk
38fbaa0
@JoernBerkefeld JoernBerkefeld mentioned this issue Oct 30, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Oct 30, 2024 that will close this issue
task/1814 filter journey builder triggeredSends from being saved to disk #1816
Merged
4 tasks
@github-actions github-actions bot closed this as completed Nov 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Closed by #1816.

@JoernBerkefeld JoernBerkefeld mentioned this issue Nov 8, 2024
Merged
11 tasks
JoernBerkefeld added a commit that referenced this issue Nov 11, 2024
@JoernBerkefeld
#1814: also exclude HiddenJourneyBuilderTriggeredSends
c4ff844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/triggeredSend COMPONENT chore Jira issue-type "Task"
Projects
None yet
Milestone
7.5.0
1 participant
@JoernBerkefeld