[BUG] Logs folder automatically created

[Francois-BellegardeOSF]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Whenever we run mcdev, even without parameters, a 'logs' folder is created.

Expected Behavior

A logs folder should only be created if something actually happens or is actually written.

I would also think that this log folders makes sense only in an initialized project.

Steps To Reproduce

1. install the current version: npm i -g mcdev
2. navigate to an empty folder
3. Run mcdev
4. Notice the new 'logs' folder that was created

Even running mcdev --version creates a 'logs' folder.

Version

3.1.3

Environment

• OS: Windows/WSL/Linux
• Node: 14.17.0, 14.18.2, 16.13.2
• npm: 7.24.2, 8.3.0, 8.5.1

Participation

• I am willing to submit a pull request for this issue.

Additional comments

No response

[JoernBerkefeld]

hi @Francois-BellegardeOSF - how does this impact you? from my current POV you are right but I fail to see the actual issue that this is causing

[Francois-BellegardeOSF]

It pollutes whatever location you call it from, even when you don't want to accomplish anything.

If you run even just mcdev --help from a location that is readonly, it shows an ugly unhandled error. I think at the very least it is a nuisance.

I'm simply reporting what I find.

[JoernBerkefeld]

fair point, understanding it now :)
soooo basically we will should not create log files unless --debug flag was given or we find ourselves in an actual mcdev-project folder

[JoernBerkefeld]

fixing the folder creation will need a rewrite of how we start logging. Right now it's simply started upon requiring/loading Util.js. I don't think we'll tackle that before the next release but potentially in a patch soon after

the read-only dir issue is a problem that needs sorting inside of winston, which is the external module we use for logging

[JoernBerkefeld]

finally tackling this ticket to then fix #969 afterwards ;-)

[github-actions]

Closed by #971.

[JoernBerkefeld]

@Francois-BellegardeOSF quick note on how I tackled this: the access issue wasn't touched buy I simply made sure that commands that don't require a log file simply don't get one anymore, regardless of the folder you are in.
Every command that ends up writing into the current folder, however, does get a log file.

To avoid log files all together for, I suppose, other reasons, you can use --noLogFile from 5.1 on.