-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Move to ESM modules #354
Labels
Milestone
Comments
DougMidgley
added
NEW
not yet analyzed new issues get this label
chore
Jira issue-type "Task"
labels
Jun 28, 2022
marking this for the next minor release, after we've gotten 4.0 on the road ;-) |
Will need to be a major release as this would break anything using commonjs referencing our project. Can be a major release JUST for this, but still needs a major. None the less, agree its a next step, not for v4 |
JoernBerkefeld
added
the
BREAKING CHANGE
requires increasing the major version of mcdev
label
May 5, 2023
DougMidgley
pushed a commit
that referenced
this issue
May 8, 2023
DougMidgley
pushed a commit
that referenced
this issue
May 8, 2023
DougMidgley
pushed a commit
that referenced
this issue
May 8, 2023
DougMidgley
pushed a commit
that referenced
this issue
May 15, 2023
DougMidgley
pushed a commit
that referenced
this issue
May 20, 2023
Merged
6 tasks
DougMidgley
pushed a commit
that referenced
this issue
Jun 3, 2023
DougMidgley
pushed a commit
that referenced
this issue
Jun 3, 2023
DougMidgley
pushed a commit
that referenced
this issue
Jun 5, 2023
DougMidgley
added a commit
that referenced
this issue
Jun 5, 2023
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
JoernBerkefeld
added a commit
that referenced
this issue
Sep 19, 2023
JoernBerkefeld
added a commit
that referenced
this issue
Sep 19, 2023
JoernBerkefeld
added a commit
that referenced
this issue
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Many dependencies are starting to support ESM only modules over CommonJS. This means moving syntax from require to import.
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
ESM modules support both ESM AND CommonJS, but there is some gotacha, including requiring a JSON file isnt possible.
The main risk i have seen in the past is affect on FS module, which no longer supports __dirname and workarounds are needed (not major). Ideally some helper methods (instead of just metadata) have test classes added before to help validate if migration affects functionality
The text was updated successfully, but these errors were encountered: