Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] git user.name / user.email does not propose current local version #599

Closed
2 tasks done
JoernBerkefeld opened this issue Dec 9, 2022 · 0 comments · Fixed by #600
Closed
2 tasks done

[BUG] git user.name / user.email does not propose current local version #599

JoernBerkefeld opened this issue Dec 9, 2022 · 0 comments · Fixed by #600
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/INIT COMPONENT e/IDE EPIC NEW not yet analyzed new issues get this label
Milestone
4.2.0

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

we seem to be only checking global settings

Expected Behavior

we should let git try to read the local config as well. Otherwise, any local git config values will always be overwritten by mcdev init / mcdev upgrade

Steps To Reproduce

  1. run git config --local user.name "test"
  2. run git config --global user.name "Your Name"
  3. Run mcdev init
  4. It will always propose "Your Name" to you

Version

4.1.12

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working e/IDE EPIC NEW not yet analyzed new issues get this label c/INIT COMPONENT labels Dec 9, 2022
@JoernBerkefeld JoernBerkefeld added this to the 4.2.0 milestone Dec 9, 2022
@JoernBerkefeld JoernBerkefeld self-assigned this Dec 9, 2022
@JoernBerkefeld JoernBerkefeld moved this to Todo in mcdev Dec 9, 2022
JoernBerkefeld added a commit that referenced this issue Dec 9, 2022
@JoernBerkefeld
#599: in mcdev init use local user name/email if found, otherwise glo…
75e875f 
…bal ones
@JoernBerkefeld JoernBerkefeld mentioned this issue Dec 9, 2022
Merged
1 task
@JoernBerkefeld JoernBerkefeld linked a pull request Dec 9, 2022 that will close this issue
#599: in mcdev init use local user name/email if found, otherwise glo… #600
Merged
1 task
JoernBerkefeld added a commit that referenced this issue Dec 12, 2022
@JoernBerkefeld
#599: replaced cli with simple-git approach
54c4d2c
JoernBerkefeld added a commit that referenced this issue Dec 12, 2022
@JoernBerkefeld
Merge pull request #600 from Accenture/bugfix/599-git-username-userem…
9364987 
…ail-does-not-propose-current-local-version

#599: in mcdev init use local user name/email if found, otherwise glo…
Repository owner moved this from Todo to Done in mcdev Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/INIT COMPONENT e/IDE EPIC NEW not yet analyzed new issues get this label
Projects
mcdev
Status: Done
Milestone
4.2.0
1 participant
@JoernBerkefeld