Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] add update/insert/delete support for journeys (interaction) #627

Closed
JoernBerkefeld opened this issue Jan 13, 2023 · 1 comment · Fixed by #631
Closed

[FEATURE] add update/insert/delete support for journeys (interaction) #627

JoernBerkefeld opened this issue Jan 13, 2023 · 1 comment · Fixed by #631
Assignees
@JoernBerkefeld
Labels
c/journey COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" PRIORITY used for professional service clients
Milestone
4.3.0

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Jan 13, 2023 •
edited
Loading

while supporting id rewrites is currently out of the question, basic deploy of already manually prepared jsons would already help.

general API overview: https://developer.salesforce.com/docs/marketing/marketing-cloud/guide/jb-api-specification.html
@JoernBerkefeld JoernBerkefeld added enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" c/journey COMPONENT PRIORITY used for professional service clients labels Jan 13, 2023
@JoernBerkefeld JoernBerkefeld added this to the 4.2.2 milestone Jan 13, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jan 13, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 4.2.2, 4.3.0 Jan 13, 2023
@JoernBerkefeld JoernBerkefeld changed the title [FEATURE] add update/insert support for journeys (interaction) [FEATURE] add update/insert/delete support for journeys (interaction) Jan 13, 2023
JoernBerkefeld added a commit that referenced this issue Jan 13, 2023
@JoernBerkefeld
#627: add delete support for interaction
8b101ed
JoernBerkefeld added a commit that referenced this issue Jan 13, 2023
@JoernBerkefeld
#627: add UPDATE support for interaction
cd06ab9
JoernBerkefeld added a commit that referenced this issue Jan 13, 2023
@JoernBerkefeld
#627: add CREATE support for interaction
86a51f0
@JoernBerkefeld JoernBerkefeld mentioned this issue Jan 13, 2023
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue Jan 13, 2023
@JoernBerkefeld
#627: allow retrieving single journeys by ID instead of key
4732b08 
IDs are visible in URL, Keys are not visible
JoernBerkefeld added a commit that referenced this issue Jan 13, 2023
@JoernBerkefeld
#627: fix typo
3e1103d
JoernBerkefeld added a commit that referenced this issue Jan 13, 2023
@JoernBerkefeld
#627: remove helper string
59c4aae
JoernBerkefeld added a commit that referenced this issue Jan 13, 2023
@JoernBerkefeld
#627: ensure interactions retrieved by id get saved with key as name
497a57b
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: disable fields for create according to docs
e0a4083
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: added generic setFolderId method
ee1c26d
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: add folder id resolution on retrieve
2ade4bb
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: add missing fields
8dd17d9
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: add check for eventDefinition
0683a0f
@JoernBerkefeld JoernBerkefeld linked a pull request Jan 16, 2023 that will close this issue
Feature/627 add BASIC create+add new version+update+delete support for journeys interaction + #611 delete eventDefinition #631
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: add DELETE by ID
babf3c3
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: encoding not needed
5b61154
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: key is required for CREATE as per API response
94e4ef2
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: add req trigger fields for update/create
e4dede5
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: delete specific journey version
01f1834 
deletes all versions if not provided!
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: allow auto-creating new draft if none exists
008a6fd
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: limit DELETE for interaction to require version
e92457b 
avoids accidental deletion of entire journey with all its versions
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: 'version' req for update to avoid 'Interaction not found'-error
edfd6cd
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: version auto-set to last server-version for update to avoid issues
614f597 
could otherwise become an issue during deployments, especially across BUs
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: dont show assumed new version because deleted versions will not…
ff88f76 
… be re-assigned on create
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: handle errors during async delete op
0f88a94
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: fix & warning for delete interaction
9b0c1a4
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: speed up caching
b077f80
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: checks for triggeredSend for retrieve/deploy
d30f073
@JoernBerkefeld JoernBerkefeld modified the milestones: 4.4.0, 4.3.0 Jan 16, 2023
JoernBerkefeld added a commit that referenced this issue Jan 16, 2023
@JoernBerkefeld
#627: version auto-set to last server-version for update to avoid issues
96ce1da
JoernBerkefeld added a commit that referenced this issue Jan 22, 2023
@JoernBerkefeld
#627: add test for RETRIEVE interaction
9b2af85
JoernBerkefeld added a commit that referenced this issue Jan 22, 2023
@JoernBerkefeld
#627: add test for DEPLOY interaction
94ebae4
JoernBerkefeld added a commit that referenced this issue Jan 22, 2023
@JoernBerkefeld
#627: add test for TEMPLATE interaction
ea32519 
required disabling escaping in Mustache and hard-wiring the use of triple curly-brackets to avoid replacemetns on the double-curly-brackets that occur in journey jsons.
JoernBerkefeld added a commit that referenced this issue Jan 23, 2023
@JoernBerkefeld
#627: promoted to retrieve-by-default
39a96b1
JoernBerkefeld added a commit that referenced this issue Jan 23, 2023
@JoernBerkefeld
#627: auto-trim leading %23 / # from ID
e57857a
JoernBerkefeld added a commit that referenced this issue Jan 23, 2023
@JoernBerkefeld
#627: clarify the limitation to journeys
0d4d496
JoernBerkefeld added a commit that referenced this issue Jan 23, 2023
@JoernBerkefeld
#627: auto-trim appended version for retrieve-by-id
2b86ff8
JoernBerkefeld added a commit that referenced this issue Jan 23, 2023
@JoernBerkefeld
#627: removed definitionId - it's basically the ID of the journey's v…
780d03a 
…ersion.
JoernBerkefeld added a commit that referenced this issue Jan 23, 2023
@JoernBerkefeld
#627: show "Downloaded (0)" if key/id and don't stop on these API-errors
2ff7508
JoernBerkefeld added a commit that referenced this issue Jan 23, 2023
@JoernBerkefeld
#627: advanced interaction-dependency resolution
5131aa9
JoernBerkefeld added a commit that referenced this issue Jan 23, 2023
@JoernBerkefeld
#627: adjust tests to changes in retrieved fields
ecbc5c9
JoernBerkefeld added a commit that referenced this issue Jan 23, 2023
@JoernBerkefeld
#627: move journey-version-param into key/id field as a req suffix
4e5c565
JoernBerkefeld added a commit that referenced this issue Jan 23, 2023
@JoernBerkefeld
#627: auto-recognition of key vs id
dfb8640
JoernBerkefeld added a commit that referenced this issue Jan 23, 2023
@JoernBerkefeld
#627: move journey-version-param into key/id field as a req suffix
bb488b0
@github-actions
Copy link

Closed by #631.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/journey COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" PRIORITY used for professional service clients
Projects
None yet
Milestone
4.3.0
1 participant
@JoernBerkefeld