Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] only first 50 transactionalX are retrieved #672

Closed
2 tasks done
JoernBerkefeld opened this issue Jan 26, 2023 · 1 comment · Fixed by #673
Closed
2 tasks done

[BUG] only first 50 transactionalX are retrieved #672

JoernBerkefeld opened this issue Jan 26, 2023 · 1 comment · Fixed by #673
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/transactionalEmail c/transactionalPush c/transactionalSms
Milestone
4.3.0

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Jan 26, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

it's simply not using pagination.

Expected Behavior

No response

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

4.2.1

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added this to the 4.3.0 milestone Jan 26, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jan 26, 2023
JoernBerkefeld added a commit that referenced this issue Jan 26, 2023
@JoernBerkefeld
#672: switch to generic retrieveREST wrapper + filter deleted items o…
f2cfc28 
…n the server + fix missing definitionId for interactions
JoernBerkefeld added a commit that referenced this issue Jan 26, 2023
@JoernBerkefeld
#672: enabled pagination and set pageSize to this API's max of 100
da10a3d
JoernBerkefeld added a commit that referenced this issue Jan 26, 2023
@JoernBerkefeld
#672: adjust api calls counter in tests
1a5fd5e
@JoernBerkefeld JoernBerkefeld mentioned this issue Jan 26, 2023
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Jan 26, 2023 that will close this issue
Bugfix/672 only first 50 transactionalx are retrieved + #676 onLoop fix + sfmc-sdk bump to 0.6.3 #673
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue Jan 26, 2023
@JoernBerkefeld
#672: adjust to breaking change in sfmc-sdk
dcc565b
JoernBerkefeld added a commit that referenced this issue Jan 29, 2023
@JoernBerkefeld
#672: bump sfmc-sdk from 0.6.2 to 0.6.3
3177ef2
@github-actions
Copy link

Closed by #673.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/transactionalEmail c/transactionalPush c/transactionalSms
Projects
None yet
Milestone
4.3.0
1 participant
@JoernBerkefeld