Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] deploy transactinoalEmail / transactionalSMS / transactionalPush fails if definitionId is in json #691

Closed
2 tasks done
JoernBerkefeld opened this issue Feb 1, 2023 · 1 comment · Fixed by #692
Closed
2 tasks done

[BUG] deploy transactinoalEmail / transactionalSMS / transactionalPush fails if definitionId is in json #691

JoernBerkefeld opened this issue Feb 1, 2023 · 1 comment · Fixed by #692
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/transactionalEmail c/transactionalPush c/transactionalSms NEW not yet analyzed new issues get this label
Milestone
4.3.1

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

image

this is an edge case because we do not store it during retrieve. however, if somebody happens to have an id in the json payload, the current configuration would send it for updates and creates which is not accepted by the API

Expected Behavior

definitionId is auto-filtered before running update/create

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

4.3.0

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working NEW not yet analyzed new issues get this label c/transactionalSms c/transactionalEmail c/transactionalPush labels Feb 1, 2023
@JoernBerkefeld JoernBerkefeld added this to the 4.3.1 milestone Feb 1, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Feb 1, 2023
JoernBerkefeld added a commit that referenced this issue Feb 1, 2023
@JoernBerkefeld
#691: remove definitionId from transactionalX payload before update a…
eb2bd76 
…nd create

API throws an error if it exists
@JoernBerkefeld JoernBerkefeld mentioned this issue Feb 1, 2023
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Feb 1, 2023 that will close this issue
#691: fix definitionId error for transactionalSMS / transactionalEmail / transactionalPush update+create #692
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue Feb 1, 2023
@JoernBerkefeld
Merge pull request #692 from Accenture/bugfix/691-deploy-transactinoa…
a506593 
…lemail-transactionalsms-transactionalpush-fails-if-definitionid-is-in-json

#691: fix definitionId error for transactionalSMS / transactionalEmail / transactionalPush update+create
@github-actions github-actions bot closed this as completed Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Closed by #692.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/transactionalEmail c/transactionalPush c/transactionalSms NEW not yet analyzed new issues get this label
Projects
None yet
Milestone
4.3.1
1 participant
@JoernBerkefeld