Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] code snippets made up of ssjs are not saved as SSJS #747

Closed
2 tasks done
JoernBerkefeld opened this issue Feb 16, 2023 · 2 comments · Fixed by #754 or #764
Closed
2 tasks done

[BUG] code snippets made up of ssjs are not saved as SSJS #747

JoernBerkefeld opened this issue Feb 16, 2023 · 2 comments · Fixed by #754 or #764
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/asset COMPONENT PRIORITY used for professional service clients
Milestone
4.3.4

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

image
only html or amp
but not ssjs is possible here

Expected Behavior

No response

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

4.3.3

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/asset COMPONENT PRIORITY used for professional service clients NEW not yet analyzed new issues get this label labels Feb 16, 2023
@JoernBerkefeld JoernBerkefeld added this to the 4.4.0 milestone Feb 16, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Feb 16, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 4.4.0, 4.3.4 Feb 16, 2023
JoernBerkefeld added a commit that referenced this issue Feb 17, 2023
@JoernBerkefeld
#747: SSJS support for codesnippets
4b9709c
@JoernBerkefeld JoernBerkefeld mentioned this issue Feb 17, 2023
Merged
3 tasks
JoernBerkefeld added a commit that referenced this issue Feb 20, 2023
@JoernBerkefeld
#747: add robust way of deciding if code block is SSJS or not and ext…
299d548 
…racting it's code
JoernBerkefeld added a commit that referenced this issue Feb 20, 2023
@JoernBerkefeld
#747: improve regex to recognize edge cases
3343d1c
JoernBerkefeld added a commit that referenced this issue Feb 20, 2023
@JoernBerkefeld
Merge pull request #754 from Accenture/bugfix/747-code-snippets-made-…
4ddac12 
…up-of-ssjs-are-not-saved-as-ssjs

bug/#747: SSJS support for codesnippets
@JoernBerkefeld JoernBerkefeld linked a pull request Feb 20, 2023 that will close this issue
bug/#747: SSJS support for codesnippets #754
Merged
3 tasks
@github-actions
Copy link

Closed by #754.

JoernBerkefeld added a commit that referenced this issue Feb 20, 2023
@JoernBerkefeld
#747: clean up logs
4db81cf
JoernBerkefeld added a commit that referenced this issue Feb 20, 2023
@JoernBerkefeld
Merge pull request #758 from Accenture/bugfix/747-code-snippets-made-…
3c60fe5 
…up-of-ssjs-are-not-saved-as-ssjs

#747: CHORE clean up logs
@JoernBerkefeld JoernBerkefeld removed the NEW not yet analyzed new issues get this label label Feb 20, 2023
@JoernBerkefeld JoernBerkefeld mentioned this issue Feb 21, 2023
Merged
@david-robuck
Copy link

This update is going to be incredibly helpful in getting our team to fully embrace using mcdev as their primary tool. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/asset COMPONENT PRIORITY used for professional service clients
Projects
None yet
Milestone
4.3.4
2 participants
@JoernBerkefeld @david-robuck