Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] support UPDATE and DELETE for mobileKeyword and extract responseMessage to AMP-file #782

Closed
JoernBerkefeld opened this issue Mar 6, 2023 · 1 comment · Fixed by #825
Closed

[FEATURE] support UPDATE and DELETE for mobileKeyword and extract responseMessage to AMP-file #782

JoernBerkefeld opened this issue Mar 6, 2023 · 1 comment · Fixed by #825
Assignees
@JoernBerkefeld
Labels
c/mobileKeyword COMPONENT e/Metadata support EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" PRIORITY used for professional service clients
Milestone
5.0.0

Comments

@JoernBerkefeld
Copy link
Contributor

this can be a 1-liner but it can also contain code and line breaks --> should be extracted into separate file, ideally and ampscript file.
image
@JoernBerkefeld JoernBerkefeld added enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" c/mobileKeyword COMPONENT labels Mar 6, 2023
@JoernBerkefeld JoernBerkefeld added this to the 4.4.0 milestone Mar 6, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Mar 6, 2023
@JoernBerkefeld JoernBerkefeld added the PRIORITY used for professional service clients label Mar 10, 2023
JoernBerkefeld added a commit that referenced this issue Mar 27, 2023
@JoernBerkefeld
#782: refactoring
dfd6c8f
JoernBerkefeld added a commit that referenced this issue Mar 27, 2023
@JoernBerkefeld
#782: extract responseMessage into seperate file
976b22c
@JoernBerkefeld JoernBerkefeld mentioned this issue Mar 27, 2023
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Mar 27, 2023 that will close this issue
Feature/782 support UPDATE and DELETE for mobileKeyword and extract responseMessage to AMP-file #825
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue Mar 29, 2023
@JoernBerkefeld
#782: add support for UPDATE to mobileKeyword
76c3905
JoernBerkefeld added a commit that referenced this issue Mar 29, 2023
@JoernBerkefeld
#782: add support for DELETE to mobileKeyword
3836b4f
JoernBerkefeld added a commit that referenced this issue Mar 29, 2023
@JoernBerkefeld
#782: add RETRIEVE test to mobileKeyword
3ebc727
@JoernBerkefeld JoernBerkefeld changed the title [FEATURE] extract responseMessage from mobileKeyword JSON into AMP file [FEATURE] support UPDATE and DELETE for mobileKeyword and extract responseMessage to AMP-file Mar 30, 2023
JoernBerkefeld added a commit that referenced this issue Mar 31, 2023
@JoernBerkefeld
#782: fix UPDATE for mobileKeyword to use the right fields
7394d65
JoernBerkefeld added a commit that referenced this issue Mar 31, 2023
@JoernBerkefeld
#782: fix CREATE logic and add CREATE TEST for mobileKeyword
450ca1f
JoernBerkefeld added a commit that referenced this issue Mar 31, 2023
@JoernBerkefeld
#782: get ID from key for DELETE method on mobileMessage
ed9b5ee
JoernBerkefeld added a commit that referenced this issue Apr 11, 2023
@JoernBerkefeld
#782: add mobileKeyword tests for delete + getFilesToCommit
decbf13
JoernBerkefeld added a commit that referenced this issue Apr 11, 2023
@JoernBerkefeld
#782: fix delete logic for mobileKeyword
f39103a
JoernBerkefeld added a commit that referenced this issue Apr 11, 2023
@JoernBerkefeld
#782: add errorCode checks for tests on mobileKeyword, mobileMessage …
548768e 
…and query
@JoernBerkefeld JoernBerkefeld mentioned this issue Apr 11, 2023
Closed
JoernBerkefeld added a commit that referenced this issue Apr 11, 2023
@JoernBerkefeld
#782: add template test for mobileKeyword
3f51cfd
JoernBerkefeld added a commit that referenced this issue Apr 11, 2023
@JoernBerkefeld
#782: add fields isInherited and restriction to templating
2267ada
JoernBerkefeld added a commit that referenced this issue Apr 11, 2023
@JoernBerkefeld
#782: first attempt to cover retrieveAsTemplate for mobileKeyword
2d552ac
JoernBerkefeld added a commit that referenced this issue Apr 12, 2023
@JoernBerkefeld
#782: standardize retrieveAsTemplate (REST only) to ensure same outco…
b215b89 
…me as in retrieve + buildTemplate
JoernBerkefeld added a commit that referenced this issue Apr 12, 2023
@JoernBerkefeld
#782: fix retrieveAsTemplate tes tfor mobileKeyword
561b72e
JoernBerkefeld added a commit that referenced this issue Apr 12, 2023
@JoernBerkefeld
#782: gracefully handle name-not-found in retrieveAsTemplate
5cef679
@github-actions
Copy link

Closed by #825.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/mobileKeyword COMPONENT e/Metadata support EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" PRIORITY used for professional service clients
Projects
None yet
Milestone
5.0.0
1 participant
@JoernBerkefeld