Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] if keywords exist multiple times due to multiples codes not all are saved #889

Closed
2 tasks done
JoernBerkefeld opened this issue May 4, 2023 · 1 comment · Fixed by #932
Closed
2 tasks done

[BUG] if keywords exist multiple times due to multiples codes not all are saved #889

JoernBerkefeld opened this issue May 4, 2023 · 1 comment · Fixed by #932
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/mobileKeyword COMPONENT PRIORITY used for professional service clients
Milestone
5.0.2

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

basically, the keyField is incorrect. It cannot be just "keyword" but it needs to be either the ID or a combination of code & key

Expected Behavior

image
these 5 entries should actually be 10, given that they each were created for 2 codes.

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

4.3.4

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working PRIORITY used for professional service clients c/mobileKeyword COMPONENT labels May 4, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.0.1 milestone May 4, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this May 4, 2023
JoernBerkefeld added a commit that referenced this issue May 12, 2023
@JoernBerkefeld
#889: switch mobileKeyword's keyField to id to avoid duplicate over…
0d22d37 
…rides
@JoernBerkefeld JoernBerkefeld mentioned this issue May 24, 2023
Merged
3 tasks
JoernBerkefeld added a commit that referenced this issue May 24, 2023
@JoernBerkefeld
#889: eslint --fix and jsdoc fixes
dc00219
@JoernBerkefeld JoernBerkefeld linked a pull request May 25, 2023 that will close this issue
Bugfix/889 if keywords exist multiple times due to multiples codes not all are saved #932
Merged
3 tasks
JoernBerkefeld added a commit that referenced this issue May 25, 2023
@JoernBerkefeld
#889: rewrite how other types check mobileKeywords
cccad4f
JoernBerkefeld added a commit that referenced this issue May 25, 2023
@JoernBerkefeld
#889: ensure mobileKeywords for which the mobileCode was deleted are …
350e6bb 
…not saved to disk
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: ensure we always keep the id if it is used as key
3a43aea
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: fix mobileKeyword test cases after switching keyField to "id"
a5d2337
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: revert previous commit
b608672
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: switch to custom keyField c__codeKeyword and support RETRIEVE
e5fff96
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: enable DELETE with new custom keyField
cc01898
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: enable DEPLOY with new custom keyField
4fc45c8
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: enable updating the keyword via changeKeyValue / changeKeyField
e4569db
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: ensure lowercased searches are not rejected
89959fb 
keywords are automatically uppercased by SFMC
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
Revert "#889: fix mobileKeyword test cases after switching keyField t…
8d35cb6 
…o "id""

This reverts commit a5d2337.

# Conflicts:
#	lib/metadataTypes/definitions/MobileKeyword.definition.js
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: fix test cases for new code.keyword custom keyField
8c8781f
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
Revert "#889: switch mobileKeyword's keyField to id to avoid duplic…
7cd3620 
…ate overrides"

This reverts commit 0d22d37.

# Conflicts:
#	docs/dist/documentation.md
#	lib/metadataTypes/MobileKeyword.js
#	lib/metadataTypes/definitions/MobileKeyword.definition.js
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: apply same code.keyword logic to retrieve and retrieveAsTemplate
751aee3
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: remove searchForMobileKeyword; reference c__codeKeyword across …
84733d5 
…other types
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: enforce upper-cased keywords in tests
0c60da4
JoernBerkefeld added a commit that referenced this issue May 26, 2023
@JoernBerkefeld
#889: enhance debug log for filtered keywords
b772bb5
@github-actions
Copy link

Closed by #932.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/mobileKeyword COMPONENT PRIORITY used for professional service clients
Projects
None yet
Milestone
5.0.2
1 participant
@JoernBerkefeld