Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] delete old interaction folder on retrieve of journey #892

Closed
2 tasks done
JoernBerkefeld opened this issue May 5, 2023 · 1 comment · Fixed by #930
Closed
2 tasks done

[BUG] delete old interaction folder on retrieve of journey #892

JoernBerkefeld opened this issue May 5, 2023 · 1 comment · Fixed by #930
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/journey COMPONENT
Milestone
5.0.2

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented May 5, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

in mcdev._retrieveBU() there is a list of renamed types as part of v4 to v5 migration which deletes old folders upon re-retrieval of a renamed type.
journey / interaction is missing there

Expected Behavior

interaction folder is deleted when journey is retrieved

Technical notes:

lib/index.js
_retrieveBU()
const renamedTypes needs to be extended

Version

5.0.0

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/journey COMPONENT labels May 5, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.0.1 milestone May 5, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this May 5, 2023
JoernBerkefeld added a commit that referenced this issue May 24, 2023
@JoernBerkefeld
#892: delete old interaction folder on retrieve of journey
c8759df
@JoernBerkefeld JoernBerkefeld mentioned this issue May 24, 2023
Merged
1 task
JoernBerkefeld added a commit that referenced this issue May 24, 2023
@JoernBerkefeld
Merge pull request #930 from Accenture/bugfix/892-delete-old-interact…
5e6d09f 
…ion-folder-on-retrieve-of-journey

#892: delete old interaction folder on retrieve of journey
@github-actions
Copy link

Closed by #930.

@JoernBerkefeld JoernBerkefeld linked a pull request May 24, 2023 that will close this issue
#892: delete old interaction folder on retrieve of journey #930
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/journey COMPONENT
Projects
None yet
Milestone
5.0.2
1 participant
@JoernBerkefeld