Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] buildDefinition and buildDefinitionBulk state they need the name when they actually take the key #909

Closed
2 tasks done
JoernBerkefeld opened this issue May 16, 2023 · 2 comments · Fixed by #931
Closed
2 tasks done

[BUG] buildDefinition and buildDefinitionBulk state they need the name when they actually take the key #909

JoernBerkefeld opened this issue May 16, 2023 · 2 comments · Fixed by #931
Assignees
@JoernBerkefeld
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone
5.0.2

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented May 16, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

the documentation in the wiki and when running mcdev --help state that bd and bdb require the name of the metadata to work when it fact it's the key in the filename of the template

Expected Behavior

clearly explain what parameter value it needs, especially in cases where the key value is part of templating but the filename of the template still bears the old name

Version

5.0.1

Participation

  • I am willing to submit a pull request for this issue.
@JoernBerkefeld JoernBerkefeld added bug Something isn't working documentation Improvements or additions to documentation labels May 16, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.0.2 milestone May 16, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this May 24, 2023
@JoernBerkefeld
Copy link
Contributor Author

updated https://github.com/Accenture/sfmc-devtools/wiki/06.c-~-Templating-Commands to talk about the "template name" and not the name or key

JoernBerkefeld added a commit that referenced this issue May 24, 2023
@JoernBerkefeld
#909: clarify that bd and bdb require the template's file name
4b0530d
@JoernBerkefeld JoernBerkefeld mentioned this issue May 24, 2023
Merged
1 task
JoernBerkefeld added a commit that referenced this issue May 24, 2023
@JoernBerkefeld
Merge pull request #931 from Accenture/bugfix/909-builddefinition-and…
5ffb804 
…-builddefinitionbulk-state-they-need-the-name-when-they-actually-take-the-key

bugfix/#909: clarify that bd and bdb require the template's file name
@github-actions
Copy link

Closed by #931.

@JoernBerkefeld JoernBerkefeld linked a pull request May 24, 2023 that will close this issue
bugfix/#909: clarify that bd and bdb require the template's file name #931
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
5.0.2
1 participant
@JoernBerkefeld