Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] allow standard github branch names to also update .git/templatemessage #914

Closed
JoernBerkefeld opened this issue May 17, 2023 · 2 comments · Fixed by #916
Closed

[TASK] allow standard github branch names to also update .git/templatemessage #914

JoernBerkefeld opened this issue May 17, 2023 · 2 comments · Fixed by #916
Assignees
@JoernBerkefeld
Labels
chore Jira issue-type "Task" e/IDE EPIC
Milestone
5.0.2

Comments

@JoernBerkefeld
Copy link
Contributor

branches created by github tend to not have feature/ or bugfix/ in front of them. our little commit message helper does not pick up on the ticket id in these cases.

also, when switching to "main", "develop" or "hotfix" the post-checkout hook fails completely with an error due to the grep not finding anything. that error should be handled gracefully and the commit msg should be updated to use "#0: "
@JoernBerkefeld JoernBerkefeld added e/IDE EPIC chore Jira issue-type "Task" labels May 17, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.0.2 milestone May 17, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this May 17, 2023
JoernBerkefeld added a commit that referenced this issue May 17, 2023
@JoernBerkefeld
#914: make "type-subfolder" in branch name optional for post-checkout…
0234e39 
… hook
@JoernBerkefeld JoernBerkefeld mentioned this issue May 17, 2023
Closed
2 tasks
JoernBerkefeld added a commit that referenced this issue May 17, 2023
@JoernBerkefeld
#914: catch error for unrecognized branch names that broke the post-c…
5557d8b 
…heckout hook
JoernBerkefeld added a commit that referenced this issue May 17, 2023
@JoernBerkefeld
#914: make "type-subfolder" in branch name optional for post-checkout…
31d83c3 
… hook
@JoernBerkefeld JoernBerkefeld mentioned this issue May 17, 2023
Merged
2 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request May 17, 2023 that will close this issue
Task/914 allow standard GitHub branch names to also update gittemplatemessage #916
Merged
2 tasks
@github-actions
Copy link

Closed by #916.

JoernBerkefeld added a commit that referenced this issue May 17, 2023
@JoernBerkefeld
#914: ensure numbers are only taken from the start
0ee272c
@JoernBerkefeld JoernBerkefeld mentioned this issue May 17, 2023
Merged
JoernBerkefeld added a commit that referenced this issue May 17, 2023
@JoernBerkefeld
Merge pull request #917 from Accenture/task/914-allow-standard-github…
6a53889 
…-branch-names-to-also-update-gittemplatemessage

#914: ensure numbers are only taken from the start
@github-actions
Copy link

Closed by #917.

@JoernBerkefeld JoernBerkefeld mentioned this issue Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
chore Jira issue-type "Task" e/IDE EPIC
Projects
None yet
Milestone
5.0.2
1 participant
@JoernBerkefeld