Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] queries not correctly formatted when other types were retrieved first #945

Closed
2 tasks done
JoernBerkefeld opened this issue May 30, 2023 · 2 comments · Fixed by #946
Closed
2 tasks done

[BUG] queries not correctly formatted when other types were retrieved first #945

JoernBerkefeld opened this issue May 30, 2023 · 2 comments · Fixed by #946
Labels
bug Something isn't working c/query COMPONENT
Milestone
5.0.2

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented May 30, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

image

Expected Behavior

query formatting should be the same independent of stuff that ran before it

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

5.0.1

Participation

  • I am willing to submit a pull request for this issue.
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/query COMPONENT labels May 30, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.0.2 milestone May 30, 2023
@JoernBerkefeld
Copy link
Contributor Author

while testing together with other tests, it seems that the tests for type JOURNEY are causing this somehow.

JoernBerkefeld added a commit that referenced this issue May 30, 2023
@JoernBerkefeld
#945: corrected expected SQL to have uppercased "AS" statements
270eb47
JoernBerkefeld added a commit that referenced this issue May 30, 2023
@JoernBerkefeld
#945: ensure we re-initialize the prettier config for each file exten…
7493647 
…sion
JoernBerkefeld added a commit that referenced this issue May 30, 2023
@JoernBerkefeld
#945: only initialize prettier config if we actually plan on saving f…
575554d 
…iles - not for caching
@JoernBerkefeld JoernBerkefeld mentioned this issue May 30, 2023
Merged
3 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request May 30, 2023 that will close this issue
Bugfix/945 queries not correctly formatted when other types were retrieved first #946
Merged
3 tasks
@github-actions
Copy link

Closed by #946.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working c/query COMPONENT
Projects
None yet
Milestone
5.0.2
1 participant
@JoernBerkefeld