Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] retrieve-by-key does not filter by key if key-list ends on comma #985

Closed
2 tasks done
JoernBerkefeld opened this issue Jun 7, 2023 · 2 comments · Fixed by #1004 or #1023
Closed
2 tasks done

[BUG] retrieve-by-key does not filter by key if key-list ends on comma #985

JoernBerkefeld opened this issue Jun 7, 2023 · 2 comments · Fixed by #1004 or #1023
Assignees
@JoernBerkefeld
Labels
bug Something isn't working PRIORITY used for professional service clients
Milestone
5.2.0

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Jun 7, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

`mcdev retrieve cred/bu "key1,key2," will run key1, then key2, then an empty key, which is basically like running retrieve without a key. We need to filter empty items from the key array (or trim commas from the start/end)

Version

5.1.0

Participation

  • I am willing to submit a pull request for this issue.
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/dataExtension COMPONENT PRIORITY used for professional service clients regression labels Jun 7, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.1.1 milestone Jun 7, 2023
@JoernBerkefeld JoernBerkefeld changed the title [BUG] retrieve-by-key does not filter by key anymore for dataExtensions [BUG] retrieve-by-key does not filter by key if key-list ends on comma Jun 7, 2023
@JoernBerkefeld JoernBerkefeld removed the c/dataExtension COMPONENT label Jun 7, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jun 27, 2023
@JoernBerkefeld
Copy link
Contributor Author

this issue existed since we added multi-key / multi-type support - we just didn't know yet

JoernBerkefeld added a commit that referenced this issue Jun 27, 2023
@JoernBerkefeld
#985: ensure trailing commas in key/type lists do not lead to unfores…
07c813f 
…een executions
@JoernBerkefeld JoernBerkefeld mentioned this issue Jun 27, 2023
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Jun 27, 2023 that will close this issue
bugfix/985: ensure trailing commas in key/type lists do not lead to unforeseen executions #1004
Merged
4 tasks
@github-actions
Copy link

Closed by #1004.

@JoernBerkefeld JoernBerkefeld modified the milestones: 5.2.1, 5.2.0 Jun 29, 2023
@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working PRIORITY used for professional service clients
Projects
None yet
Milestone
5.2.0
1 participant
@JoernBerkefeld