Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/38 fix keys should ask to retrieve other types #1064

Merged

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Aug 2, 2023

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (via [TASK] Documentation for 5.2 #1007)

@JoernBerkefeld JoernBerkefeld added this to the 5.2.0 milestone Aug 2, 2023
@JoernBerkefeld JoernBerkefeld requested a review from phjulia August 2, 2023 09:00
@JoernBerkefeld JoernBerkefeld self-assigned this Aug 2, 2023
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Coverage Report

Commit:6dcb2d2
Base: develop@731fefa

Type Base This PR
Total Statements Coverage  51.59%  51.64%  (+0.05%)
Total Branches Coverage  41.35%  41.41%  (+0.06%)
Total Functions Coverage  60.1%  60.28%  (+0.18%)
Total Lines Coverage  51.5%  51.55%  (+0.05%)
Details (changed files):
File Statements Branches Functions Lines
lib/index.js  54.86%  46.96%  57.69%  54.76%
lib/metadataTypes/MetadataType.js  68.13%  66.48%  74.41%  67.98%
lib/util/cli.js  23.45%  22.39%  16.66%  23.55%
lib/util/util.js  64.15%  55.68%  77.35%  64.2%

@JoernBerkefeld JoernBerkefeld merged commit 2b73379 into develop Aug 2, 2023
@JoernBerkefeld JoernBerkefeld deleted the feature/38-fixKeys_should_ask_to_retrieve_other_types branch August 2, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant