Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1108 allow importing certain parts of mcdev directly #1116

Merged
merged 9 commits into from
Sep 29, 2023
Merged

Feature/1108 allow importing certain parts of mcdev directly #1116

merged 9 commits into from
Sep 29, 2023

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Sep 29, 2023 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added e/Core EPIC BREAKING CHANGE requires increasing the major version of mcdev labels Sep 29, 2023
@JoernBerkefeld JoernBerkefeld added this to the 6.0.0 milestone Sep 29, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 29, 2023
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Sep 29, 2023
@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited
Loading

Coverage Report

Commit:2b98fe5
Base: develop@6fd5b63

Type Base This PR
Total Statements Coverage  63.4%  63.4%  (+0%)
Total Branches Coverage  67.06%  67.01%  (-0.05%)
Total Functions Coverage  72.27%  72.14%  (-0.13%)
Total Lines Coverage  63.4%  63.4%  (+0%)
Details (changed files):
File Statements Branches Functions Lines
lib/MetadataTypeDefinitions.js  100%  100%  100%  100%
lib/MetadataTypeInfo.js  100%  100%  100%  100%
lib/index.js  67.03%  50%  64.51%  67.03%

@JoernBerkefeld JoernBerkefeld linked an issue Sep 29, 2023 that may be closed by this pull request
[FEATURE] allow importing certain parts of mcdev directly #1108
Closed
@JoernBerkefeld JoernBerkefeld merged commit a7fc973 into develop Sep 29, 2023
6 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/1108-allow-importing-certain-parts-of-mcdev-directly branch September 29, 2023 13:48
@github-actions github-actions bot mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
BREAKING CHANGE requires increasing the major version of mcdev e/Core EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] allow importing certain parts of mcdev directly
1 participant
@JoernBerkefeld