Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/1157 mcdev strips content before and after script tag upon retrieval #1158

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Bugfix/1157 mcdev strips content before and after script tag upon retrieval #1158

merged 3 commits into from
Jan 8, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • [-] Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld self-assigned this Jan 8, 2024
@JoernBerkefeld JoernBerkefeld added the c/asset COMPONENT label Jan 8, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Jan 8, 2024 that may be closed by this pull request
[BUG] Mcdev strips content before and after script tag upon retrieval #1157
Closed
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Jan 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Coverage Report

Commit:40b8237
Base: develop@8e008d3

Type This PR
Total Statements Coverage  64.36%
Total Branches Coverage  67.16%
Total Functions Coverage  73.35%
Total Lines Coverage  64.36%
Details (changed files):
File Statements Branches Functions Lines
lib/util/util.js  79.37%  75.2%  84.84%  79.37%

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 8, 2024
View reviewed changes
lib/util/util.js Dismissed Show dismissed Hide dismissed
@JoernBerkefeld JoernBerkefeld added this to the 6.0.1 milestone Jan 8, 2024
@JoernBerkefeld JoernBerkefeld merged commit 64f512d into develop Jan 8, 2024
5 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bugfix/1157-mcdev-strips-content-before-and-after-script-tag-upon-retrieval branch January 8, 2024 16:31
@github-actions github-actions bot mentioned this pull request Jan 8, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/asset COMPONENT
Projects
None yet
Milestone
6.0.1
Development

Successfully merging this pull request may close these issues.

[BUG] Mcdev strips content before and after script tag upon retrieval
1 participant
@JoernBerkefeld